test: mark web lock held test as flaky #59144
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59144 +/- ##
==========================================
+ Coverage 90.04% 90.07% +0.03%
==========================================
Files 648 648
Lines 191078 191078
Branches 37452 37454 +2
==========================================
+ Hits 172050 172115 +65
+ Misses 11649 11590 -59
+ Partials 7379 7373 -6 🚀 New features to boost your workflow:
|
panva
reviewed
Jul 21, 2025
jasnell
approved these changes
Jul 21, 2025
joyeecheung
added
the
fast-track
|
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Oh wait, others are expected failures. |
|
@joyeecheung yes those are expected |
github-actions
bot
removed
the
request-ci
aduh95
added
author ready
panva
force-pushed
the
ishabi/web-lock-held-flaky
branch
from
e6a7ce2 to
4dd919a
Compare
panva
approved these changes
Jul 27, 2025
|
I'll look into the nature of these tests, it would appear the unhandled rejections are expected, so maybe all we need is to add a handler for the workers that execute the tests where this is expected. In the meantime, i've pushed my suggestion above which might actually work to ignore the flakyness. |
github-actions
bot
removed
the
request-ci
|
Aside: the test harness does set up addEventListener("unhandledrejection") for these tests, which, i'm assuming, Node.js doesn't support? am I right? |
It does (tested locally by forcing an unhandled rejection in the wpt in question). |
panva
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/59144 ✔ Done loading data for nodejs/node/pull/59144 ----------------------------------- PR info ------------------------------------ Title test: mark web lock held test as flaky (#59144) Author Ilyas Shabi <[email protected]> (@IlyasShabi) Branch IlyasShabi:ishabi/web-lock-held-flaky -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: mark web lock held test as flaky Committers 1 - Filip Skokan <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59144 Refs: https://github.com/nodejs/node/issues/59142 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59144 Refs: https://github.com/nodejs/node/issues/59142 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 21 Jul 2025 14:12:30 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/59144#pullrequestreview-3038872131 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/59144#pullrequestreview-3059408069 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/59144#pullrequestreview-3059412213 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-07-27T09:09:58Z: https://ci.nodejs.org/job/node-test-pull-request/68235/ - Querying data for job/node-test-pull-request/68235/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/16550345467 |
panva
removed
the
commit-queue-failed
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in cd1a90d |
aduh95
pushed a commit
that referenced
this pull request
Jul 27, 2025
PR-URL: #59144 Refs: #59142 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
meteorqz6
pushed a commit
to meteorqz6/node
that referenced
this pull request
Aug 2, 2025
PR-URL: nodejs#59144 Refs: nodejs#59142 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #59142