-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
test: update startCLI
to set --port=0
by default
#59042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update startCLI
to set --port=0
by default
#59042
Conversation
081472b
to
80edf69
Compare
update the `startCLI` debugging testing utility to set by default the port to use to `0` (i.e. a random port)
80edf69
to
bee555a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59042 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.02%
==========================================
Files 641 648 +7
Lines 188846 190967 +2121
Branches 37049 37429 +380
==========================================
+ Hits 170087 171966 +1879
- Misses 11476 11620 +144
- Partials 7283 7381 +98 🚀 New features to boost your workflow:
|
Co-authored-by: Antoine du Hamel <[email protected]>
thanks @aduh95 🙏 |
@dario-piotrowicz don't forget to add
author ready
|
Sorry, I have forgotten about the label lately, I'll be more careful, thanks 🙏 |
Landed in 29626f8 |
update the `startCLI` debugging testing utility to set by default the port to use to `0` (i.e. a random port) PR-URL: #59042 Reviewed-By: Antoine du Hamel <[email protected]>
update the
startCLI
debugging testing utility to set by default the port to use to0
(i.e. a random port)To me this sounds like the most appropriate default behavior since:
startCLI
calls currently indeed do that(for example see: test: add missing port=0 arg in test-debugger-extract-function-name #58977)
startCLI
call, if they didn't the test would always fail (instead of generally passing but with potential flakes)