Skip to content

Backport of [UI] - run colocated components codemod into release/1.20.x #31406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 252 commits into
base: release/1.20.x
Choose a base branch
from

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #31397 to be assessed for backporting due to the inclusion of the label backport/1.20.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@zofskeez
This person should resolve the merge-conflict(s) by either:

  • Manually completing the cherry picks into this branch
  • Creating a new branch and manually cherry-picking all commits being backported

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

There were still a good number of component templates left in the templates/components directory. Ember has long supported (2019!) colocation of components and their templates. Handily, there is also a codemod that will do this change for you. There was one hiccup in that the codemod is old enough, it doesn't recognize some newer syntax, but there is also a PR to fix this issue.

This PR is the result of running this command in the ui directory:

npx github:apellerano-pw/ember-component-template-colocation-migrator#major-bump-ember-template-recast-v3-to-v6

JIRA ticket

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.


Overview of commits

* Update vault-plugin-auth-gcp to v0.21.0

* Add changelog

---------

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>
* Update vault-plugin-auth-azure to v0.21.0

* Add changelog

---------

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>
* pull in 1.19 doc updates for backport to 1.20

* add 1.20 to hsm entry
* Add missing protocol path table to CMPv2 API documentation

* Update CODEOWNERS for PKI api-docs
* add h1 page title and update styling
* most important scep docs

* oops. forgot to commit everything.

* Add docs around SCEP auth

* More SCEP api doc updates

* Add return_full_ca_chain parameter to SCEP config docs

* Remove duplicated EST sections

* Update missing SCEP reference within pki/index.mdx

* PR feedback

* PR feedback 2

* Rename return_full_ca_chain to restrict_ca_chain_to_issuer

* Apply suggestions from code review

Co-authored-by: Yoko Hyakuna <[email protected]>

* Apply suggestions from code review

Co-authored-by: Sarah Chavis <[email protected]>

* Tweaks to review suggestions from Sarah

* Apply suggestions from code review

Co-authored-by: Sarah Chavis <[email protected]>

* Fix typo

* Fix typo

---------

Co-authored-by: Kit Haines <[email protected]>
Co-authored-by: Yoko Hyakuna <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
…page (#30865)

* move helper text above code editor

* move above header
* remove 1.19 from the versioned redirect

* one more fix
* re-enable 1.19.x as ce_active

* add 1.17.x back

* set 1.17.x ce_active to false

---------

Co-authored-by: davidadeleon <[email protected]>
* Update vault-plugin-secrets-alicloud to v0.20.0

* Add changelog

* Update go.mod spacing

---------

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>
Co-authored-by: Michael Blaum <[email protected]>
* Update vault-plugin-auth-jwt to v0.24.1

* Add changelog

---------

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>
* Update vault-plugin-secrets-terraform to v0.12.0

* Add changelog

---------

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>
* Update table layout

* fix weird headers
* Update vault-plugin-auth-kubernetes to v0.22.1

* Add changelog

---------

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>
* remove omitempty to ensure valid is always returned

* add changelog

* add test
* ce changes for hashicorp/vault-enterprise#8193

* lower case enterprise only errors

---------

Co-authored-by: Ben Ash <[email protected]>
* test assertion for form fields

* resuse const cars

* add tests

* remove conditionals for attr.name

* link jira VAULT-36640

* test assertion for form fields

* resuse const cars

* add tests

* remove conditionals for attr.name

* [UI] removed guard for `this.hideLabel` and `this.labelString` for migrated HDS components

* reverty copy pasta

---------

Co-authored-by: Cristiano Rastelli <[email protected]>
bosouza and others added 20 commits July 23, 2025 11:33
)

* support open-api secret recovery operations

* add changelog

* Update changelog/31331.txt

Co-authored-by: miagilepner <[email protected]>

---------

Co-authored-by: miagilepner <[email protected]>
* userpass is not case sensitive
* ldap is case sensitive when it is configured that way

---------

Co-authored-by: Ben Ash <[email protected]>
* Completed initial replacement of editor

* fixing ts issues

* removing codemirror modifier and deps

* working on replacing the code editor

* addressing linting concerns

* cleaning up policy-form editor

* fixing linting issues

* fixing linting issues

* fixing tests

* fixing tests

* fixing tests

* fixing tests

* fixing failing tests

* cleaning up PR

* fixing tests

* remove outdated message for navigating editor

* fix linting in tests

* add changelog

* fix tests

* update naming

* remove unused lint param + name changes

* update test selector usage

* update test selector usage

* update test selector usage

* lint fixes

* replace page object selectors

* lint fix

* fix lint

* fix lint after merge

* update tests

* remove import

---------

Co-authored-by: Lane Wetmore <[email protected]>
…e updates in nightly tests (#31333)

* Add option to control write/read from cache independently

* Cleanup enabled from key
* VAULT-35602: adding Enos LDAP Tests

* adding godaddy tests

* updating external integration target module name
…ng removal stage (#31215)

* HCL dup attr deprecation: pending removal

* correct docs

* add changelog

* better error message for possible common errors

* Update website/content/partials/deprecation/duplicate-hcl-attributes.mdx

Co-authored-by: Yoko Hyakuna <[email protected]>

* Update website/content/partials/deprecation/duplicate-hcl-attributes.mdx

Co-authored-by: Luis (LT) Carbonell <[email protected]>

---------

Co-authored-by: Yoko Hyakuna <[email protected]>
Co-authored-by: Luis (LT) Carbonell <[email protected]>
* added changelog records for minor release

* PQC algorithm changelog edits

---------

Co-authored-by: lursu <[email protected]>
Co-authored-by: Scott G. Miller <[email protected]>
…CE & Ent (#31255)

* removed artifactory_username

* updated artifactory token

* ran enos fmt

* ran terraform fmt

* debugging/ testing - pinned enos version, added null username

* byyyyy
* (enos) Add KMIP Enos Test Suite

* skip KMIP for CE runs

* reads...

* cleanup variables

* fix
* update greys to use hds tokens

* update blue vars

* remove unused color vars

* replace remaining colors, add hex codes in commnets

* update kv rgp color

* remove color_variables file and use hds tokens directly
* use hds alert component, update tests delete page objects

* move token to next row

* revert compact alert

* remove a11y overrides for control group tests
* adding clause for external plugin to tooltip

* fixing mouseover event

* fix check

* pulling object out of list

* fix used parameter

* adding comments

* fix

* fixing tests

* adding 1 more test

* update tooltip func, remove excess params, update tests
* VAULT-38228 CE side of sighup for observations

* reload CE
* VAULT-37303 CE changes

* changelog
…31274)

After googleapis/google-cloud-go#11519, errors
must be checked with `errors.Is`.

Addresses #31125.

Co-authored-by: Mike Palmiotto <[email protected]>
* adds form for auth method and updates mount backend form to use it

* fixes tests
Copy link

vercel bot commented Aug 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vault-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2025 4:06pm

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 1, 2025
Copy link

hashicorp-cla-app bot commented Aug 1, 2025

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


30 out of 31 committers have signed the CLA.

  • roooms
  • sgmiller
  • zamoore
  • zofskeez
  • ryancragun
  • aslamovamir
  • rculpepper
  • mickael-hc
  • timmjd
  • meirish
  • miagilepner
  • Younique98
  • elliesterner
  • himanshu-8693
  • kporter101
  • bosouza
  • giogranda85
  • brewgator
  • kevin-loehfelm
  • VioletHynes
  • davidadeleon
  • steved
  • pmoranga
  • akshya96
  • wenzel-felix
  • drivera258
  • hellobontempo
  • Soromeister
  • lursu
  • tvo0813
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

github-actions bot commented Aug 1, 2025

CI Results:
All Go tests succeeded! ✅

@tomcf-hcp tomcf-hcp modified the milestones: 1.20.2, 1.20.3 Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.