Skip to content

[VAULT-38229] Enable test timing cache restore without requiring cache updates in nightly tests #31333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2025

Conversation

brewgator
Copy link
Contributor

Description

CE portion of https://github.com/hashicorp/vault-enterprise/pull/8469

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@brewgator brewgator requested a review from a team as a code owner July 18, 2025 13:18
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 18, 2025
Copy link

github-actions bot commented Jul 18, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jul 18, 2025

Build Results:
All builds succeeded! ✅

tvo0813
tvo0813 previously approved these changes Jul 18, 2025
Copy link
Collaborator

@tvo0813 tvo0813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the pipeline failing

@brewgator brewgator enabled auto-merge (squash) July 23, 2025 18:00
@brewgator brewgator requested a review from tvo0813 July 23, 2025 18:20
@brewgator brewgator merged commit 266f8e5 into main Jul 23, 2025
71 of 72 checks passed
@brewgator brewgator deleted the lt/VAULT-38229 branch July 23, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants