Skip to content

CE changes for plugin download #30927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Conversation

helenfufu
Copy link
Contributor

Description

This PR follows the How To Merge PRs Containing CE + Ent Changes guide to generate the subset of CE changes from https://github.com/hashicorp/vault-enterprise/pull/8193.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@helenfufu helenfufu requested review from thyton and benashz June 9, 2025 22:57
@helenfufu helenfufu requested review from a team as code owners June 9, 2025 22:57
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 9, 2025
@helenfufu helenfufu added this to the 1.20.0-rc milestone Jun 9, 2025
thyton
thyton previously approved these changes Jun 9, 2025
Copy link

github-actions bot commented Jun 9, 2025

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Jun 9, 2025

CI Results:
All Go tests succeeded! ✅

@helenfufu helenfufu force-pushed the VAULT-34895/import-secure-plugin-api branch 2 times, most recently from c82792b to 5c0a5df Compare June 9, 2025 23:39
@helenfufu helenfufu force-pushed the VAULT-34895/import-secure-plugin-api branch from 5c0a5df to 785f268 Compare June 10, 2025 00:06
@thyton thyton self-requested a review June 10, 2025 00:37
thyton
thyton previously approved these changes Jun 10, 2025
@benashz benashz requested a review from lursu June 10, 2025 14:10
@lursu lursu merged commit 146c032 into main Jun 10, 2025
92 checks passed
@lursu lursu deleted the VAULT-34895/import-secure-plugin-api branch June 10, 2025 14:31
drivera258 pushed a commit that referenced this pull request Jun 11, 2025
* ce changes for hashicorp/vault-enterprise#8193

* lower case enterprise only errors

---------

Co-authored-by: Ben Ash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.20.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants