UI: Stablize control group tests #31390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
CI Results: |
hellobontempo
commented
Jul 29, 2025
| @@ -48,23 +48,25 @@ | |||
| </div> | |||
|
|
|||
| {{#if (or (not this.model.requestEntity) this.currentUserIsRequesting)}} | |||
| <div class="message is-highlight" data-test-accessor-callout> | |||
There was a problem hiding this comment.
slowly working to remove the message css class
hellobontempo
commented
Jul 29, 2025
| <code class="is-word-break" data-test-accessor-value>{{this.model.id}}</code> | ||
| </div> | ||
| </div> | ||
| <Hds::Alert |
hellobontempo
commented
Jul 29, 2025
| @@ -32,13 +25,6 @@ module('Integration | Component | control group success', function (hooks) { | |||
| requestEntity: { id: 'requestor', name: 'entity8509' }, | |||
| reload: sinon.stub(), | |||
| }; | |||
| setRunOptions({ | |||
There was a problem hiding this comment.
these overrides are no longer necessary! a11y tests pass without it 🎉
hellobontempo
commented
Jul 29, 2025
|
|
||
| module('Acceptance | Enterprise | control groups', function (hooks) { | ||
| setupApplicationTest(hooks); | ||
|
|
||
| hooks.beforeEach(function () { | ||
| setRunOptions({ |
There was a problem hiding this comment.
this override is no longer necessary! a11y tests pass without it 🎉
hellobontempo
commented
Jul 29, 2025
| } | ||
| }; | ||
|
|
||
| skip('it allows the full flow to work without a saved token', async function (assert) { |
There was a problem hiding this comment.
ran these in a for loop to confirm they are not going to be flaky (or at lest try to confirm they won't be..)
|
✅ enterprise tests pass |
lane-wetmore
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hds::Alertin control group component to make component a11y compliantTODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.