UI: Add assertion to FormField for @attr.name and @model args
#30788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
hellobontempo
changed the title
FormField for @attr.name and @model args
|
@hellobontempo I think we've reached a consensus that this is the way to go. Do you mind doing also the second part in this PR, which is to remove the guards too? In this way there is a single ticket and it's easier to track the changes and why. Thanks |
Yes! Absolutely. I'm a little busy feature testing until code freeze next Friday but I can update afterward. Feel free to takeover the PR/branch if this is blocking you until then 😄 |
didoo
force-pushed
the
ui/add-form-field-assertion
branch
from
3486983 to
e5bbee0
Compare
…grated HDS components
…ult into ui/add-form-field-assertion
|
Build Results: |
zofskeez
approved these changes
Jun 10, 2025
6 tasks
didoo
added a commit
that referenced
this pull request
Jun 11, 2025
drivera258
pushed a commit
that referenced
this pull request
Jun 11, 2025
* test assertion for form fields * resuse const cars * add tests * remove conditionals for attr.name * link jira VAULT-36640 * test assertion for form fields * resuse const cars * add tests * remove conditionals for attr.name * [UI] removed guard for `this.hideLabel` and `this.labelString` for migrated HDS components * reverty copy pasta --------- Co-authored-by: Cristiano Rastelli <[email protected]>
didoo
added a commit
that referenced
this pull request
Jun 26, 2025
didoo
added a commit
that referenced
this pull request
Jun 27, 2025
didoo
added a commit
that referenced
this pull request
Jun 27, 2025
didoo
added a commit
that referenced
this pull request
Jun 27, 2025
didoo
added a commit
that referenced
this pull request
Jun 30, 2025
didoo
added a commit
that referenced
this pull request
Jun 30, 2025
…DS block (#30771) * [UI] Updated `FormField` to use `Hds::Form::Checkbox` for `type/editType=boolean` (#34798) * [UI] Updated `FormField` tests for `type/editType=boolean` (#34798) * [UI] Fixed failing test cases from `FormField` `boolean` updates (#34798) * [UI] fixes raised in PR review (#34798) * removed `this.labelString` guard per agreement see #30788 * [UI] replaced `assert.ok` with `assert.true` per code review suggestion * updated `isHdsFormField` logic to reflect more accurately inital “logic” flow in the `form-field.hbs` template file for context: https://hashicorp.slack.com/archives/C05DGFEBCP2/p1751023770911809 * fixed test that was erroneously changed in previous PR due to an undetected bug the previous code was generating a `checkbox` instead of a `toggleButton` it’s now been fixed (see previous commit) * Update ui/lib/core/addon/components/form-field.hbs Co-authored-by: claire bontempo <[email protected]> --------- Co-authored-by: claire bontempo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
✅ enterprise tests pass
VAULT-36640
@attr.namekey and@modelarghideLabelguard and thethis.labelStringguard from the migrated HDS components (per decision documented here)TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.