-
Notifications
You must be signed in to change notification settings - Fork 338
Prepare Makefile to make CTSM5.4 fsurdat/landuse datasets #3482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha-ctsm5.4.CMIP7
Are you sure you want to change the base?
Prepare Makefile to make CTSM5.4 fsurdat/landuse datasets #3482
Conversation
…ing direct radiation to fates (which is scaled).
…-IntelliSense extension in MS VS Code
…-IntelliSense extension in MS VS Code
…ructions to put it into play
Add fortls to ctsm_pylib, add a .vscode directory and a couple settings
Adding dask to ctsm_pylib
Update the ctsm5.4 alpha branch to ctsm5.3.071 PR ESCOMP#3464
Merge b4bdev 20251002
ctsm5.3.079: Update submodules to match versions in cesm3_0_alpha07e (+ CMEPS)
Blocked by #3529 to be unblocked when @lawrencepj1 provides new ctsm54 lai raw dataset that includes pft 15 (as our codes expect). UPDATE FROM MEETING WITH @ekluzek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slevis-lmwg and I went over this and this is all great. One suggestion is to add a comment somewhere about the need to break up the ne3 historical into three separate jobs, because the low number of processors makes it take a long time.
And also we realized that the 1x1_brazil grids needed some changes. This wasn't quite right in the Grids document, so we corrected it there.
The bottom line with this is that want the datasets created to match the document.
Ooops I got ahead of myself and put Peter's new lai and soilcolor files in this PR. |
I recommend separating the part that changes results for the surface datasets into a different PR. Otherwise it gets lost in the part that doesn't change answers, which is most of what this PR is about. |
I suggest bringing this into the alpha branch and make a tag for it. You could rerun the testing, but as it doesn't touch model code, I'd just make sure the makefile works, and create a softlink to the previous baselines. |
Update submodules to match versions in cesm3_0_alpha07e (+ CMEPS)
@ekluzek I updated this PR to the latest tag in the alpha branch but ALSO to the latest tag in master (LMK if this does not make sense to you). I started testing to confirm that I didn't mess anything up. This PR's tag will still be "12" since it only changes answers due to the changes in master. Again LMK if you disagree:
|
@ekluzek
|
Yeah, this is something good to be on the same page about. Although since it's a branch it's not as important as on main branches. But, the ctsm5.4 branch is an important one, so probably good to sync up on. I prefer having the "11" updated whenever there are changes along the branch even if they don't change answers. And I prefer doing a separate PR for a merge update, and not mixing it with other changes. Basically that means a few more tags, so the steps are more clearly defined and separable. For a PR that is solely just a merge to a later ctsm tag, I'd leave the "11" alone, because it represents a change in the ctsm base version, and NOT on the branch. It's helpful to think of the "11" as the number of tags along the branch that don't change the base version, and the final ctsm tag part to be the ctsm tag it's based off of. So "11" shows there were 11 tagged sets of changes that diverge from master, and the difference in ctsm version from the last tag (ctsm5.3.075) from the first ctsm5.4 tag (ctsm5.3.40) shows the span of ctsm versions that the ctsm5.4 has gone through. We do want to be on the same page about the naming convention for alpha tags. But, I don't want to dictate too much about how people handle their PR's. So we can do things slightly differently there, IMHO. |
Description of changes
Updating
tools/mksurfdata_esmf/Makefile
to accommodate new fsurdat/landuse listpython/ctsm/toolchain/gen_mksurfdata_jobscript_multi.py
to accommodate new fsurdat/landuse listinput_pftdata_filename
as per Logistical improvements to fsurdat/landuse files #2337Removing checkboxes from rest of list because need to make this tag before generating new datasets:
make all
default_data_1850.cfg
which is used by the Makefilemake all-subset
default_data_2000.cfg
which is used for making NEON/PLUMBER fsurdat filesnamelist_defaults
with the new (CTSM5.4) fsurdat/landuse filesSpecific notes
Contributors other than yourself, if any:
@ekluzek
CTSM Issues Fixed (include github issue #):
Fixes #1775
Fixes #2337
Fixes #2785
Fixes #3304
Fixes #3452
Addresses parts of #2851
Any other ctsm5.4-related or other issues?
Are answers expected to change (and if so in what way)?
Yes, because replacing fsurdat/landuse files.
Any User Interface Changes (namelist or namelist defaults changes)?
Update namelist_defaults with new fsurdat/landuse files.
Does this create a need to change or add documentation? Did you do so?
Update #3364 as needed.
Testing performed, if any:
None so far.