-
Notifications
You must be signed in to change notification settings - Fork 338
alpha-ctsm5.4.CMIP7.12.ctsm5.3.075: Add support for CLM_CMIP_ERA (= "cmip6" or "cmip7") #3501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alpha-ctsm5.4.CMIP7.12.ctsm5.3.075: Add support for CLM_CMIP_ERA (= "cmip6" or "cmip7") #3501
Conversation
@ekluzek this is how far I got today. The next two days will be very busy, and I may take Friday off. I would benefit from your corrections and/or comments on where to focus next, as this perl/xml interface is not my forte :-) |
Submitting the same three tests as above. |
Same behavior in the first two, as I expected and hoped.
floating divide by zero ctsm_sci FAIL RUNs to address:
The ERI test points to 5.4 finidat and 5.3 fsurdat; update the fsurdat?
The SMS test points to 5.3 finidat and 5.4 fsurdat; update the finidat?
|
Regarding most recent commit 14f647d: On a different note, as per today's software meeting (2025/10/2): |
@ekluzek now that I've added back the cmip6 defaults for IHist cases, it seems silly to omit them for I2000 cases, so I will add them for consistency. |
UPDATE FROM MEETING WITH @ekluzek Skip this list below. Instead, consider the "lai streams" test an expected failure and merge this PR. Resolve the expected failure in the later PR where I add Peter's new raw lai dataset and new raw noanthro dataset.
|
@ekluzek this PR is ready for me to merge and needs your approval first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, We had already gone through this. I had one comment from our discussion that I neglected to push go on earlier.
I also have some comments/questions on the XML variable description.
Approving, this is ready to go from my perspective, you can decide on how to handle my suggestions. It would be good to get the other PR to ctsm5.4 alpha branch, and then for this one run baselines and bring it in right away.
My testing is up-to-date:
|
Description of changes
Definition of DONE in the issue #3471
Specific notes
Contributors other than yourself, if any:
@ekluzek
CTSM Issues Fixed (include github issue #):
Resolves #3471
Resolves #3311
Resolves #1733
Resolves #3250
Half of #3050
Are answers expected to change (and if so in what way)?
No.
Any User Interface Changes (namelist or namelist defaults changes)?
The CLM_CMIP_ERA flag became necessary because we will not have SSP and NOANTHRO pft raw datasets for CTSM5.4. This means that SSP and NOANTHRO cases default to cmip6 fsurdat/landuse files, while other cases default to cmip6 fsurdat/landuse files.
Does this create a need to change or add documentation? Did you do so?
May need to update #3364
Testing performed, if any:
So far...