Skip to content

Conversation

jamesbiggs
Copy link
Collaborator

@jamesbiggs jamesbiggs commented May 3, 2023

Ticket URL: UN-589

About these changes

Wagtail 5.0 upgrade!

How to check these changes

Check that the site works, upgrade considerations have been met, and ensure that 5.0 has been applied.

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer.
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
  • Ensured that PR includes only commits relevant to the ticket.
  • Waited for all CI jobs to pass before requesting a review.
  • Added/updated tests and documentation where relevant.

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #860 (0f128da) into develop (c7d5e9f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #860      +/-   ##
===========================================
+ Coverage    81.39%   81.43%   +0.03%     
===========================================
  Files          109      109              
  Lines         3806     3808       +2     
===========================================
+ Hits          3098     3101       +3     
+ Misses         708      707       -1     
Impacted Files Coverage Δ
etna/core/models/basepage.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jamesbiggs jamesbiggs marked this pull request as ready for review May 4, 2023 13:00
@jamesbiggs
Copy link
Collaborator Author

Hey @ababic, I think this one's ready to review when you're free!

For the deprecation warning - I've created a PR on wagtailmedia's repo - not sure if it's any good but if it gets accepted that should stop the deprecation warning.

@jamesbiggs jamesbiggs requested a review from ababic May 4, 2023 13:02
@jamesbiggs jamesbiggs added dependencies Pull requests that update a dependency file python Pull requests that update Python code cross-team labels May 4, 2023
@ababic ababic force-pushed the feature/UN-589-wagtail-5.0 branch from daf8bd9 to 0f128da Compare May 5, 2023 16:41
Copy link
Contributor

@ababic ababic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me locally :)

@ababic ababic merged commit bd3ac84 into develop May 5, 2023
@ababic ababic deleted the feature/UN-589-wagtail-5.0 branch May 5, 2023 16:47
janehughes pushed a commit that referenced this pull request May 11, 2023
* develop: (33 commits)
  CHORE: Update Poetry install options for platform.sh (#878)
  CHORE: Upgrade poetry to 1.4.2 (#877)
  UN-589: Wagtail 5.0 upgrade (#860)
  DF-644: Add `uuid` field to all page types (#844)
  UN-470: Fix FeaturedRecordArticleBlock TemplateSyntaxError (#866)
  [UN-538] Update semantics for record details component (#864)
  CHORE: Changed content warning colour to `color__grey-2` (#859)
  UN-556: Featured Story CTA label is not descriptive enough (#856)
  UN-551: "Read more" and "Read less" button label not descriptive (#857)
  UN-558: Breadcrumb separator is announced as "greater than" (#855)
  [UN-562] Add aria-expanded attribute to gallery button (#847)
  [UN-549] Record Revealed - Missing icon (#833)
  [UN-547] Record revealed - only interactive elements should be focusable (#835)
  UN-560: View the record CTA sr-only repeats the name of the full record which is very verbose (#832)
  UN-572: Remove `heading` from `QuoteBlock` (#842)
  Un 506 content warning (#843)
  UN-555: Featured Article "New" label is marked with a `role="link"` attribute (#831)
  DF-630: Add `skos_id` fields for entities that map to official categories (#822)
  UN-574: Remove unused `CollectionHighlights` and `ResultsPage` (#846)
  [UN-536] Multiple duplicate IDs for article descriptions (#839)
  ...

# Conflicts:
#	scripts/src/modules/analytics/search/search_sort_filters_tracking.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants