Skip to content

Conversation

ababic
Copy link
Contributor

@ababic ababic commented May 10, 2023

Resolves build errors for me locally. Hopefully, the same will be true of platform.sh :)

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #877 (596ab60) into develop (c7d5e9f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #877      +/-   ##
===========================================
+ Coverage    81.39%   81.43%   +0.03%     
===========================================
  Files          109      109              
  Lines         3806     3808       +2     
===========================================
+ Hits          3098     3101       +3     
+ Misses         708      707       -1     
Impacted Files Coverage Δ
etna/core/models/basepage.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TNA-Allan TNA-Allan self-requested a review May 10, 2023 09:35
Copy link
Collaborator

@TNA-Allan TNA-Allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ababic

@TNA-Allan TNA-Allan merged commit 0fa7d31 into develop May 10, 2023
@ababic ababic deleted the fix/upgrade-poetry-to-1.4.2 branch May 10, 2023 09:36
janehughes pushed a commit that referenced this pull request May 11, 2023
* develop: (33 commits)
  CHORE: Update Poetry install options for platform.sh (#878)
  CHORE: Upgrade poetry to 1.4.2 (#877)
  UN-589: Wagtail 5.0 upgrade (#860)
  DF-644: Add `uuid` field to all page types (#844)
  UN-470: Fix FeaturedRecordArticleBlock TemplateSyntaxError (#866)
  [UN-538] Update semantics for record details component (#864)
  CHORE: Changed content warning colour to `color__grey-2` (#859)
  UN-556: Featured Story CTA label is not descriptive enough (#856)
  UN-551: "Read more" and "Read less" button label not descriptive (#857)
  UN-558: Breadcrumb separator is announced as "greater than" (#855)
  [UN-562] Add aria-expanded attribute to gallery button (#847)
  [UN-549] Record Revealed - Missing icon (#833)
  [UN-547] Record revealed - only interactive elements should be focusable (#835)
  UN-560: View the record CTA sr-only repeats the name of the full record which is very verbose (#832)
  UN-572: Remove `heading` from `QuoteBlock` (#842)
  Un 506 content warning (#843)
  UN-555: Featured Article "New" label is marked with a `role="link"` attribute (#831)
  DF-630: Add `skos_id` fields for entities that map to official categories (#822)
  UN-574: Remove unused `CollectionHighlights` and `ResultsPage` (#846)
  [UN-536] Multiple duplicate IDs for article descriptions (#839)
  ...

# Conflicts:
#	scripts/src/modules/analytics/search/search_sort_filters_tracking.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants