UN-574: Remove unused CollectionHighlights and ResultsPage
#846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ababic
reviewed
Apr 27, 2023
ababic
reviewed
Apr 27, 2023
Codecov Report
@@ Coverage Diff @@
## develop #846 +/- ##
===========================================
+ Coverage 81.24% 81.29% +0.05%
===========================================
Files 108 108
Lines 3833 3786 -47
===========================================
- Hits 3114 3078 -36
+ Misses 719 708 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Couple of small things @jamesbiggs:
|
|
Hey @ababic, I've made the changes you requested :) |
ababic
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
It sure does feel nice to shed this code! Thanks @jamesbiggs!
5 tasks
janehughes
pushed a commit
that referenced
this pull request
May 2, 2023
* develop: UN-560: View the record CTA sr-only repeats the name of the full record which is very verbose (#832) UN-572: Remove `heading` from `QuoteBlock` (#842) Un 506 content warning (#843) UN-555: Featured Article "New" label is marked with a `role="link"` attribute (#831) DF-630: Add `skos_id` fields for entities that map to official categories (#822) UN-574: Remove unused `CollectionHighlights` and `ResultsPage` (#846) [UN-536] Multiple duplicate IDs for article descriptions (#839) un-564 Update to centre view to open button on closure of image gallery (#838) [UN-561] Increase icon contrast (#845) [UN-546] Remove unused aria-labelledby attribute (#840) [UN-534] [UN-548] Add boundary borders to featured content areas for high contrast mode (#836) UN-563: Close button does not provide sufficient context (#819) UN-583: Highlight Gallery + Record Article pages visible in Topic + Time Period pages (#841) DF-643:Archive details resolve links (#837) [DF-376] Tracking when a user sorts results or changes result view (#779) DF-611: location filter for archive (#826) [UN-540] Jumplink focus state (#830) [UN-541] Add scrolling for sidebar nav (#829) UN-576: Run `poetry update` (#834) [DF-587] Remove extra (unneeded?) <form> element (#828) # Conflicts: # templates/includes/icons/sprites.html # templates/includes/image_gallery.html
Merged
janehughes
pushed a commit
that referenced
this pull request
May 11, 2023
* develop: (33 commits) CHORE: Update Poetry install options for platform.sh (#878) CHORE: Upgrade poetry to 1.4.2 (#877) UN-589: Wagtail 5.0 upgrade (#860) DF-644: Add `uuid` field to all page types (#844) UN-470: Fix FeaturedRecordArticleBlock TemplateSyntaxError (#866) [UN-538] Update semantics for record details component (#864) CHORE: Changed content warning colour to `color__grey-2` (#859) UN-556: Featured Story CTA label is not descriptive enough (#856) UN-551: "Read more" and "Read less" button label not descriptive (#857) UN-558: Breadcrumb separator is announced as "greater than" (#855) [UN-562] Add aria-expanded attribute to gallery button (#847) [UN-549] Record Revealed - Missing icon (#833) [UN-547] Record revealed - only interactive elements should be focusable (#835) UN-560: View the record CTA sr-only repeats the name of the full record which is very verbose (#832) UN-572: Remove `heading` from `QuoteBlock` (#842) Un 506 content warning (#843) UN-555: Featured Article "New" label is marked with a `role="link"` attribute (#831) DF-630: Add `skos_id` fields for entities that map to official categories (#822) UN-574: Remove unused `CollectionHighlights` and `ResultsPage` (#846) [UN-536] Multiple duplicate IDs for article descriptions (#839) ... # Conflicts: # scripts/src/modules/analytics/search/search_sort_filters_tracking.js
jamesbiggs
deleted the
feature/UN-574-remove-unused-collection-highlights
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket URL: https://national-archives.atlassian.net/browse/UN-574
About these changes
Removed all code relating to
CollectionHighlightsandResultsPageHow to check these changes
Where possible, provide guidance to help your reviewer
Before assigning to reviewer, please make sure you have
Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md