Changed SearchField with partial_match to AutocompleteField
#204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey all, I've been using Wagtail for a few months now, and am fairly new to open-source code. If I've missed any steps, or should/could do something differently - please let me know. Hopefully these changes are okay! |
zerolab
requested changes
May 4, 2023
5 tasks
zerolab
approved these changes
May 4, 2023
There was a problem hiding this comment.
LGTM. Thank you @jamesbiggs
Will look at making a new release tomorrow morning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was made to satisfy this issue: #203
Simple PR that changes the
SearchFields that havepartial_match=Trueto useAutocompleteFieldand removepartial_match, which is bringing in aRemovedInWagtail60Warningwhen upgrading towagtail5.0.Note: This is my first pull request/edit on an open-source repo. Sorry if I've missed anything or done something wrong - I'm open to learning! 😄