feat: implement MASQUE connect-udp #2796
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
force-pushed
the
connect-udp
branch
2 times, most recently
from
6ca95fe to
4893499
Compare
Client/server transfer resultsPerformance differences relative to 02b78b8. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
mxinden
force-pushed
the
connect-udp
branch
3 times, most recently
from
843c209 to
b9aa6f2
Compare
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct ConnectUdpSession { |
There was a problem hiding this comment.
Consider naming this:
Suggested change
| pub struct ConnectUdpSession { | |
| pub struct Session { |
| impl Display for WebTransportRequest { | ||
| fn fmt(&self, f: &mut Formatter) -> fmt::Result { | ||
| write!(f, "WebTransport session {}", self.stream_handler) | ||
| } | ||
| } | ||
|
|
||
| impl Display for ConnectUdpRequest { |
There was a problem hiding this comment.
Ordering is a bit odd here. Either all types first, then all implementations; or, all definitions for the same type together.
neqo-http3/tests/connect_udp.rs
Outdated
| anti_replay, fixture_init, now, CountingConnectionIdGenerator, DEFAULT_ADDR, DEFAULT_ALPN_H3, | ||
| DEFAULT_KEYS, DEFAULT_SERVER_NAME, | ||
| }; | ||
| #[test] |
There was a problem hiding this comment.
Suggested change
| #[test] | |
| #[test] |
echo.py
Outdated
| import socket | ||
|
|
||
| HOST = '127.0.0.1' # Listen on all interfaces | ||
| PORT = 12345 # Arbitrary non-privileged port |
There was a problem hiding this comment.
Consider using process.argv[] for these. I'd want tests that include IPv6 as well.
Benchmark resultsPerformance differences relative to 02b78b8. 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [205.21 ms 205.57 ms 205.97 ms]
thrpt: [485.51 MiB/s 486.46 MiB/s 487.31 MiB/s]
change:
time: [−0.0151% +0.2522% +0.5275%] (p = 0.07 > 0.05)
thrpt: [−0.5248% −0.2516% +0.0152%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: 💚 Performance has improved. time: [295.05 ms 296.60 ms 298.13 ms]
thrpt: [33.542 Kelem/s 33.715 Kelem/s 33.893 Kelem/s]
change:
time: [−6.4650% −5.8618% −5.2441%] (p = 0.00 < 0.05)
thrpt: [+5.5344% +6.2268% +6.9119%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [28.293 ms 28.391 ms 28.504 ms]
thrpt: [35.083 B/s 35.222 B/s 35.344 B/s]
change:
time: [−0.5704% +0.0527% +0.6468%] (p = 0.87 > 0.05)
thrpt: [−0.6426% −0.0527% +0.5737%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [203.98 ms 204.28 ms 204.64 ms]
thrpt: [488.67 MiB/s 489.52 MiB/s 490.24 MiB/s]
change:
time: [−0.9912% −0.7714% −0.5518%] (p = 0.00 < 0.05)
thrpt: [+0.5548% +0.7774% +1.0012%]
decode 4096 bytes, mask ff: No change in performance detected. time: [11.609 µs 11.651 µs 11.699 µs]
change: [−0.6540% −0.2229% +0.1765%] (p = 0.30 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0615 ms 3.0710 ms 3.0822 ms]
change: [−0.4843% −0.0037% +0.4757%] (p = 0.97 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.430 µs 19.489 µs 19.549 µs]
change: [−0.6347% +0.2698% +1.3559%] (p = 0.61 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0819 ms 5.0933 ms 5.1064 ms]
change: [−0.3588% +0.0043% +0.3569%] (p = 0.97 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5303 µs 5.5597 µs 5.5946 µs]
change: [−1.1663% −0.0402% +0.7540%] (p = 0.95 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7647 ms 1.7731 ms 1.7829 ms]
change: [−0.8530% +0.3136% +1.2647%] (p = 0.60 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [88.266 ns 88.591 ns 88.936 ns]
change: [−0.5985% −0.0326% +0.5125%] (p = 0.91 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [105.97 ns 106.28 ns 106.61 ns]
change: [−0.6725% −0.2197% +0.2307%] (p = 0.34 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [105.34 ns 105.61 ns 105.97 ns]
change: [−0.3004% +0.1562% +0.6655%] (p = 0.55 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [88.876 ns 93.003 ns 102.15 ns]
change: [−1.2861% +1.7016% +6.6204%] (p = 0.61 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [107.95 ms 108.02 ms 108.09 ms]
change: [+0.1497% +0.4002% +0.5687%] (p = 0.00 < 0.05)
sent::Packets::take_ranges: :green_heart: Performance has improved. time: [5.0879 µs 5.1546 µs 5.2115 µs]
change: [−41.678% −35.644% −21.268%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [36.622 ms 36.710 ms 36.804 ms]
change: [+0.2906% +0.6217% +0.9602%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [37.613 ms 37.711 ms 37.811 ms]
change: [+0.4973% +0.9030% +1.2941%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [36.499 ms 36.556 ms 36.614 ms]
change: [+0.2462% +0.5364% +0.8033%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [37.990 ms 38.080 ms 38.182 ms]
change: [−0.4986% −0.1967% +0.1292%] (p = 0.24 > 0.05)
Download data for |
mxinden
force-pushed
the
connect-udp
branch
2 times, most recently
from
0a016ff to
98ab4fb
Compare
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to c535de9. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
==========================================
- Coverage 95.49% 93.05% -2.44%
==========================================
Files 115 117 +2
Lines 34439 35052 +613
Branches 34439 35052 +613
==========================================
- Hits 32887 32618 -269
- Misses 1545 1608 +63
- Partials 7 826 +819
|
|
Should we have some MASQUE bench? |
|
Yes. I have a work-in-progress MASQUE proxy server implementation here. Adding a benchmark similar to the Download benchmark will thus be doable. |
mxinden
force-pushed
the
connect-udp
branch
2 times, most recently
from
4128a81 to
9253723
Compare
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Aug 15, 2025
Also to stay consistent with upcoming MASQUE connect-udp implementation. See Martin's comment in mozilla#2796 (comment).
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Aug 23, 2025
Enables benchmarking of mozilla#2796. Fixes mozilla#2728. Fixes mozilla#2804.
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Aug 23, 2025
Enables benchmarking of mozilla#2796. Fixes mozilla#2728. Fixes mozilla#2804.
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Aug 23, 2025
Enables benchmarking of mozilla#2796. Fixes mozilla#2728. Fixes mozilla#2804.
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Aug 24, 2025
Enables benchmarking of mozilla#2796. Fixes mozilla#2728. Fixes mozilla#2804.
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Aug 24, 2025
Enables benchmarking of mozilla#2796. Fixes mozilla#2728. Fixes mozilla#2804.
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Aug 24, 2025
Enables benchmarking of mozilla#2796. Fixes mozilla#2728. Fixes mozilla#2804.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements RFC 9298.