-
Notifications
You must be signed in to change notification settings - Fork 139
docs(http3): remove partially outdated docs #2859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2859 +/- ##
==========================================
- Coverage 94.93% 94.92% -0.01%
==========================================
Files 115 115
Lines 34484 34484
Branches 34484 34484
==========================================
- Hits 32736 32734 -2
Misses 1741 1741
- Partials 7 9 +2
|
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to a4eb5e5. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Client/server transfer resultsPerformance differences relative to 3c7c965. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
Benchmark resultsPerformance differences relative to 3c7c965. 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.time: [202.03 ms 202.53 ms 203.06 ms] thrpt: [492.46 MiB/s 493.76 MiB/s 494.97 MiB/s] change: time: [−0.3987% −0.0607% +0.2620%] (p = 0.73 > 0.05) thrpt: [−0.2613% +0.0607% +0.4003%] 1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.time: [304.69 ms 306.19 ms 307.68 ms] thrpt: [32.501 Kelem/s 32.660 Kelem/s 32.820 Kelem/s] change: time: [−1.1713% −0.4878% +0.2005%] (p = 0.16 > 0.05) thrpt: [−0.2001% +0.4902% +1.1851%] 1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.time: [28.295 ms 28.445 ms 28.610 ms] thrpt: [34.953 B/s 35.156 B/s 35.341 B/s] change: time: [−0.4433% +0.2217% +0.9271%] (p = 0.53 > 0.05) thrpt: [−0.9186% −0.2212% +0.4452%] 1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed.time: [209.14 ms 209.39 ms 209.66 ms] thrpt: [476.96 MiB/s 477.57 MiB/s 478.16 MiB/s] change: time: [+1.0743% +1.3033% +1.5338%] (p = 0.00 < 0.05) thrpt: [−1.5106% −1.2865% −1.0628%] decode 4096 bytes, mask ff: No change in performance detected.time: [11.611 µs 11.645 µs 11.687 µs] change: [−0.6938% +0.0277% +0.7348%] (p = 0.95 > 0.05) decode 1048576 bytes, mask ff: No change in performance detected.time: [3.0047 ms 3.0140 ms 3.0250 ms] change: [−0.5512% −0.0718% +0.3861%] (p = 0.75 > 0.05) decode 4096 bytes, mask 7f: No change in performance detected.time: [19.384 µs 19.437 µs 19.495 µs] change: [−0.3087% +0.1350% +0.5644%] (p = 0.55 > 0.05) decode 1048576 bytes, mask 7f: No change in performance detected.time: [5.0834 ms 5.0946 ms 5.1074 ms] change: [−0.3120% +0.0143% +0.3321%] (p = 0.92 > 0.05) decode 4096 bytes, mask 3f: No change in performance detected.time: [5.5326 µs 5.5659 µs 5.6038 µs] change: [−3.1359% −1.2977% +0.0210%] (p = 0.11 > 0.05) decode 1048576 bytes, mask 3f: Change within noise threshold.time: [1.7636 ms 1.7749 ms 1.7903 ms] change: [+0.2327% +0.8874% +1.8366%] (p = 0.01 < 0.05) coalesce_acked_from_zero 1+1 entries: No change in performance detected.time: [88.208 ns 88.539 ns 88.878 ns] change: [−0.5775% +0.0031% +0.5758%] (p = 0.99 > 0.05) coalesce_acked_from_zero 3+1 entries: No change in performance detected.time: [105.59 ns 105.91 ns 106.24 ns] change: [−1.3622% −0.2888% +0.5672%] (p = 0.61 > 0.05) coalesce_acked_from_zero 10+1 entries: No change in performance detected.time: [105.01 ns 105.43 ns 105.94 ns] change: [−0.3966% +0.0742% +0.5685%] (p = 0.77 > 0.05) coalesce_acked_from_zero 1000+1 entries: No change in performance detected.time: [88.832 ns 88.944 ns 89.066 ns] change: [−7.4917% −2.4791% +0.5349%] (p = 0.43 > 0.05) RxStreamOrderer::inbound_frame(): No change in performance detected.time: [107.80 ms 107.90 ms 108.04 ms] change: [−0.2734% −0.0706% +0.1116%] (p = 0.52 > 0.05) sent::Packets::take_ranges: :green_heart: Performance has improved.time: [5.0530 µs 5.1412 µs 5.2334 µs] change: [−41.811% −35.596% −24.351%] (p = 0.00 < 0.05) transfer/pacing-false/varying-seeds: Change within noise threshold.time: [36.961 ms 37.034 ms 37.110 ms] change: [+0.9402% +1.2327% +1.5071%] (p = 0.00 < 0.05) transfer/pacing-true/varying-seeds: Change within noise threshold.time: [37.637 ms 37.761 ms 37.894 ms] change: [+0.2289% +0.6897% +1.1250%] (p = 0.00 < 0.05) transfer/pacing-false/same-seed: Change within noise threshold.time: [36.523 ms 36.592 ms 36.666 ms] change: [−1.0304% −0.7314% −0.4273%] (p = 0.00 < 0.05) transfer/pacing-true/same-seed: No change in performance detected.time: [38.057 ms 38.127 ms 38.198 ms] change: [−0.1857% +0.1119% +0.4049%] (p = 0.46 > 0.05) Download data for |
This list is neither complete, nor in my opinion particularly helpful. Given that I am about to add a couple more functions to
Http3Connection
with #2796, instead of updating the list, I suggest we remove it.