refactor(http3): remove module_name_repetition lint #2860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also to stay consistent with upcoming MASQUE connect-udp implementation. See Martin's comment in mozilla#2796 (comment).
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2860 +/- ##
==========================================
- Coverage 95.49% 95.47% -0.03%
==========================================
Files 115 115
Lines 34439 34437 -2
Branches 34439 34437 -2
==========================================
- Hits 32889 32879 -10
- Misses 1543 1551 +8
Partials 7 7
|
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 5723e5c. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to c535de9. 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved. time: [199.63 ms 199.94 ms 200.26 ms]
thrpt: [499.36 MiB/s 500.16 MiB/s 500.93 MiB/s]
change:
time: [−1.6416% −1.3400% −1.0658%] (p = 0.00 < 0.05)
thrpt: [+1.0773% +1.3582% +1.6690%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [303.29 ms 304.85 ms 306.39 ms]
thrpt: [32.638 Kelem/s 32.803 Kelem/s 32.972 Kelem/s]
change:
time: [−0.9885% −0.2818% +0.4744%] (p = 0.46 > 0.05)
thrpt: [−0.4722% +0.2826% +0.9984%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [28.126 ms 28.220 ms 28.323 ms]
thrpt: [35.307 B/s 35.436 B/s 35.554 B/s]
change:
time: [−0.7743% −0.1574% +0.4170%] (p = 0.60 > 0.05)
thrpt: [−0.4153% +0.1576% +0.7804%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [203.22 ms 203.52 ms 203.80 ms]
thrpt: [490.67 MiB/s 491.35 MiB/s 492.08 MiB/s]
change:
time: [−1.6825% −1.4945% −1.3079%] (p = 0.00 < 0.05)
thrpt: [+1.3252% +1.5172% +1.7113%]
decode 4096 bytes, mask ff: No change in performance detected. time: [11.582 µs 11.607 µs 11.639 µs]
change: [−1.8835% −0.5388% +0.5024%] (p = 0.46 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0607 ms 3.0706 ms 3.0818 ms]
change: [−0.4935% −0.0184% +0.4973%] (p = 0.94 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.381 µs 19.439 µs 19.506 µs]
change: [−0.9762% −0.3251% +0.1888%] (p = 0.30 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0915 ms 5.1049 ms 5.1200 ms]
change: [−0.0943% +0.2619% +0.6231%] (p = 0.16 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5159 µs 5.5393 µs 5.5679 µs]
change: [−0.8275% −0.3048% +0.1656%] (p = 0.25 > 0.05)
decode 1048576 bytes, mask 3f: Change within noise threshold. time: [1.7580 ms 1.7627 ms 1.7689 ms]
change: [+0.0061% +0.2801% +0.6269%] (p = 0.04 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [88.309 ns 88.597 ns 88.875 ns]
change: [−0.4975% −0.0486% +0.3878%] (p = 0.83 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [106.09 ns 106.42 ns 106.78 ns]
change: [−0.2183% +0.1550% +0.5700%] (p = 0.45 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [105.60 ns 106.02 ns 106.53 ns]
change: [−0.2590% +0.3262% +0.8630%] (p = 0.27 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [88.901 ns 96.999 ns 109.41 ns]
change: [−0.6549% +4.2014% +11.049%] (p = 0.20 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [107.44 ms 107.50 ms 107.57 ms]
change: [−0.4955% −0.3870% −0.2836%] (p = 0.00 < 0.05)
sent::Packets::take_ranges: :green_heart: Performance has improved. time: [5.0975 µs 5.1669 µs 5.2274 µs]
change: [−41.860% −35.738% −24.075%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [36.501 ms 36.581 ms 36.661 ms]
change: [−0.1396% +0.1602% +0.4719%] (p = 0.29 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [37.275 ms 37.380 ms 37.488 ms]
change: [−0.5252% −0.1587% +0.2262%] (p = 0.42 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [36.019 ms 36.091 ms 36.169 ms]
change: [−2.5313% −2.2827% −1.9997%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [37.811 ms 37.901 ms 37.997 ms]
change: [−0.6114% −0.2679% +0.0854%] (p = 0.14 > 0.05)
Download data for |
Client/server transfer resultsPerformance differences relative to c535de9. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
larseggert
reviewed
Aug 16, 2025
larseggert
approved these changes
Aug 16, 2025
martinthomson
approved these changes
Aug 18, 2025
|
@mxinden is there anything we can do to improve coverage? |
|
It looks like |
I created #2879 for this. I will merge this one now. |
|
@larseggert whenever you have a minute, can you manually merge here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also to stay consistent with upcoming MASQUE connect-udp implementation. See Martin's comment in
#2796 (comment).