chore: Remove dead code (#2880)

* chore: Remove dead code

Based on coverage. We should check if there is some code that _should_ have been called...

* Restore some bits needed by Gecko, and add TODOs for them.

* Apply suggestion from @martinthomson

Co-authored-by: Martin Thomson <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>

* fmt

* write_frames_with_early_return -> write_frames. Remove one qtrace.

* Restore some WT code we might want to call from gecko.

* Fix comment

---------

Signed-off-by: Lars Eggert <[email protected]>
Co-authored-by: Martin Thomson <[email protected]>

Author: larseggert

neqo-bin/src/client/mod.rs

@@ -436,7 +436,7 @@ impl<'a, H: Handler> Runner<'a, H> {
             handler,
             args,
             timeout: None,
-            recv_buf: RecvBuf::new(),
+            recv_buf: RecvBuf::default(),
         }
     }
 

neqo-bin/src/server/mod.rs

@@ -280,7 +280,7 @@ impl<S: HttpServer> Runner<S> {
             server,
             timeout: None,
             sockets,
-            recv_buf: RecvBuf::new(),
+            recv_buf: RecvBuf::default(),
         }
     }
 

neqo-common/src/codec.rs

@@ -493,12 +493,6 @@ impl<B: Buffer> AsMut<[u8]> for Encoder<B> {
     }
 }
 
-impl<'a> From<Decoder<'a>> for Encoder {
-    fn from(dec: Decoder<'a>) -> Self {
-        Self::from(&dec.buf[dec.offset..])
-    }
-}
-
 impl From<&[u8]> for Encoder {
     fn from(buf: &[u8]) -> Self {
         Self {

neqo-common/src/qlog.rs

@@ -82,11 +82,6 @@ impl Qlog {
         })
     }
 
-    #[must_use]
-    pub fn inner(&self) -> Rc<RefCell<Option<SharedStreamer>>> {
-        Rc::clone(&self.inner)
-    }
-
     /// Create a disabled `Qlog` configuration.
     #[must_use]
     pub fn disabled() -> Self {

neqo-crypto/src/aead.rs

@@ -6,7 +6,7 @@
 
 use std::{
     fmt,
-    ops::{Deref, DerefMut},
+    ops::Deref,
     os::raw::{c_char, c_uint},
     ptr::null_mut,
 };

neqo-crypto/src/agent.rs

@@ -414,6 +414,7 @@ impl SecretAgentInfo {
     pub const fn alpn(&self) -> Option<&String> {
         self.alpn.as_ref()
     }
+    // TODO: Not used in neqo, but Gecko calls it. Needs a test to call it.
     #[must_use]
     pub const fn signature_scheme(&self) -> SignatureScheme {
         self.signature_scheme

neqo-crypto/src/auth.rs

@@ -44,6 +44,7 @@ impl From<AuthenticationStatus> for PRErrorCode {
 
 // Note that this mapping should be removed after gecko eventually learns how to
 // map into the enumerated type.
+// TODO: Not used in neqo, but Gecko calls it. Needs a test to call it.
 impl From<PRErrorCode> for AuthenticationStatus {
     fn from(v: PRErrorCode) -> Self {
         Self::from_repr(v).unwrap_or(Self::Unknown)

neqo-crypto/src/cert.rs

@@ -94,11 +94,13 @@ impl CertificateInfo {
         self.certs.into_iter()
     }
 
+    // TODO: Not used in neqo, but Gecko calls it. Needs a test to call it.
     #[must_use]
     pub const fn stapled_ocsp_responses(&self) -> Option<&Vec<Vec<u8>>> {
         self.stapled_ocsp_responses.as_ref()
     }
 
+    // TODO: Not used in neqo, but Gecko calls it. Needs a test to call it.
     #[must_use]
     pub const fn signed_cert_timestamp(&self) -> Option<&Vec<u8>> {
         self.signed_cert_timestamp.as_ref()

neqo-crypto/src/p11.rs

@@ -7,7 +7,7 @@
 use std::{
     cell::RefCell,
     fmt::{self, Debug, Formatter},
-    ops::{Deref, DerefMut},
+    ops::Deref,
     os::raw::c_uint,
     ptr::null_mut,
     slice::Iter as SliceIter,
@@ -68,12 +68,6 @@ macro_rules! scoped_ptr {
             }
         }
 
-        impl DerefMut for $scoped {
-            fn deref_mut(&mut self) -> &mut *mut $target {
-                &mut self.ptr
-            }
-        }
-
         impl Drop for $scoped {
             fn drop(&mut self) {
                 unsafe { _ = $dtor(self.ptr) };

neqo-crypto/src/replay.rs

@@ -5,7 +5,7 @@
 // except according to those terms.
 
 use std::{
-    ops::{Deref, DerefMut},
+    ops::Deref,
     os::raw::c_uint,
     ptr::null_mut,
     time::{Duration, Instant},