add source-build pre-built detection #933

oleksandr-didyk · 2023-01-02T14:23:52Z

Resolves #932

Additionally created a subscription for the dependency on runtime (disabled until this PR is merged):

https://github.com/dotnet/runtime (.NET 8) ==> 'https://github.com/dotnet/sourcelink' ('main')
  - Id: e02204af-e240-492f-2682-08daecc8f206
  - Update Frequency: EveryWeek
  - Enabled: False
  - Batchable: False
  - PR Failure Notification tags:
  - Merge Policies: []

CC: @MichaelSimons @crummel

azure-pipelines.yml

src/SourceLink.Tools/Microsoft.SourceLink.Tools.Package.csproj

KalleOlaviNiemitalo · 2023-01-02T15:50:31Z

Will the title of this PR be copied to the release notes as is? If so, please include "source-build" in it. I totally expected "pre-build detection" to be a new feature that detects if the CI pipeline has run nbgv get-version already and then skips the NBGV tasks during MSBuild.

Uh I suppose I got confused about the repository as well.

eng/Versions.props

eng/Version.Details.xml

eng/cibuild.sh

mthalman · 2023-04-10T20:31:12Z

@oleksandr-didyk - Can you give a status on this please? Is there in-progress work or is it blocked or just pending work? Thanks

oleksandr-didyk · 2023-04-11T10:55:28Z

@oleksandr-didyk - Can you give a status on this please? Is there in-progress work or is it blocked or just pending work? Thanks

It was initially waiting for the Arcade bump to flow in. The change got into main last week so this PR got unblocked.
I updated it and it should be ready for re-review now

eng/SourceBuildPrebuiltBaseline.xml

eng/Version.Details.xml

eng/SourceBuildPrebuiltBaseline.xml

eng/Versions.props

NuGet.config

eng/SourceBuildPrebuiltBaseline.xml

ViktorHofer · 2023-04-18T09:40:42Z

OK there's one more PR that I just submitted that will again make things easier and this PRs diff much smaller: #1003. I suggest to also wait for that one.

ViktorHofer · 2023-05-04T16:39:18Z

src/dotnet-sourcelink/dotnet-sourcelink.csproj

@@ -4,6 +4,7 @@
    <TargetFrameworks>$(NetCurrent)</TargetFrameworks>
    <!-- Allow tool to roll forward to a newer major version. -->
    <RollForward>Major</RollForward>
+    <ExcludeFromSourceBuild>true</ExcludeFromSourceBuild>


Why does this tool need to be excluded from source build? Please add a comment as it isn't clear just from reading the code.

I did it based on the project's description:

<Description>Command line tool for SourceLink testing.</Description>

Since I thought it is a tool used for testing, but reading it again I might be wrong here. Maybe @tmat can clarify it

Additionally

<PackAsToolShimRuntimeIdentifiers>win-x64;win-x86;osx-x64</PackAsToolShimRuntimeIdentifiers>

causes some additional packages to get pulled in that are marked as pre-builts:

<Usage Id="Microsoft.AspNetCore.App.Runtime.osx-x64" Version="8.0.0-preview.3.23177.8" /> <Usage Id="Microsoft.AspNetCore.App.Runtime.win-x64" Version="8.0.0-preview.3.23177.8" /> <Usage Id="Microsoft.AspNetCore.App.Runtime.win-x86" Version="8.0.0-preview.3.23177.8" /> <Usage Id="Microsoft.NETCore.App.Host.osx-x64" Version="8.0.0-preview.3.23174.8" /> <Usage Id="Microsoft.NETCore.App.Host.win-x64" Version="8.0.0-preview.3.23174.8" /> <Usage Id="Microsoft.NETCore.App.Host.win-x86" Version="8.0.0-preview.3.23174.8" /> <Usage Id="Microsoft.NETCore.App.Runtime.osx-x64" Version="8.0.0-preview.3.23174.8" /> <Usage Id="Microsoft.NETCore.App.Runtime.win-x64" Version="8.0.0-preview.3.23174.8" /> <Usage Id="Microsoft.NETCore.App.Runtime.win-x86" Version="8.0.0-preview.3.23174.8" />

It should be included. This is not a shipping product yet but it is meant to be. It's for customers to test that their binaries have correct Source Link.

This is not a shipping product yet

Can this be done as a separate issue to not block this PR? Or it being excluded for some time is a no-go?
Specifically since the assets pulled in by PackAsToolShimRuntimeIdentifiers are non-Linux; or can this property be simply excluded? (as source-build is Linux-only for now)

IMO if source build repositories currently don't depend on the tool, it shouldn't be an issue to exclude it for now and track enabling it.

Created an issue for it -> #1028

Updated [Microsoft.SourceLink.GitHub](https://github.com/dotnet/sourcelink) from 1.1.1 to 8.0.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.SourceLink.GitHub's releases](https://github.com/dotnet/sourcelink/releases)._ ## 8.0.0 ## What's Changed **Source Link is now included in .NET SDK 8 and enabled by default. Projects that migrate to .NET SDK 8 do not need to reference Source Link packages explicitly via `PackageReference` anymore.** * Add sparse checkout support by @pakrym in dotnet/sourcelink#772 * Add support for Gitee by @luocs in dotnet/sourcelink#922 * Fix target Input Output as to not interfere with incremental. by @yuehuang010 in dotnet/sourcelink#901 * Prepare for inclusion in .NET SDK by @tmat in dotnet/sourcelink#988 * Avoid creating source link .json file when no source control mapping is available by @tmat in dotnet/sourcelink#989 * Do not report warnings when SourceLink packages are not referenced ex… by @tmat in dotnet/sourcelink#991 * Bump version to 8.0 to match SDK by @tmat in dotnet/sourcelink#992 * Fix FileWrites by @tmat in dotnet/sourcelink#995 * Remove unnecessary <?xml tags by @ViktorHofer in dotnet/sourcelink#1013 * Remove unnecessary license header in msbuild by @ViktorHofer in dotnet/sourcelink#1014 * Allow multiple Source Link assemblies to be loaded from different locations by @tmat in dotnet/sourcelink#1034 * New command-line APIs and `offline` argument by @NikolaMilosavljevic in dotnet/sourcelink#1068 * Do not report warning if submodule dir is missing by @tmat in dotnet/sourcelink#1078 ## New Contributors * @MichaelSimons made their first contribution in dotnet/sourcelink#836 * @alexperovich made their first contribution in dotnet/sourcelink#867 * @ShreyasJejurkar made their first contribution in dotnet/sourcelink#892 * @pakrym made their first contribution in dotnet/sourcelink#772 * @IanKemp made their first contribution in dotnet/sourcelink#889 * @luocs made their first contribution in dotnet/sourcelink#922 * @yuehuang010 made their first contribution in dotnet/sourcelink#901 * @NikolaMilosavljevic made their first contribution in dotnet/sourcelink#994 * @oleksandr-didyk made their first contribution in dotnet/sourcelink#933 * @v-chayan made their first contribution in dotnet/sourcelink#1054 **Full Changelog**: dotnet/sourcelink@1.1.1...8.0.0 Commits viewable in [compare view](dotnet/sourcelink@1.1.1...8.0.0). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.SourceLink.GitHub&package-manager=nuget&previous-version=1.1.1&new-version=8.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xkonti <[email protected]>

oleksandr-didyk commented Jan 2, 2023

View reviewed changes

azure-pipelines.yml Outdated Show resolved Hide resolved

oleksandr-didyk commented Jan 2, 2023

View reviewed changes

src/SourceLink.Tools/Microsoft.SourceLink.Tools.Package.csproj Outdated Show resolved Hide resolved

oleksandr-didyk changed the title ~~add pre-build detection~~ add source-build pre-build detection Jan 3, 2023

oleksandr-didyk changed the title ~~add source-build pre-build detection~~ add source-build pre-built detection Jan 3, 2023

oleksandr-didyk mentioned this pull request Jan 3, 2023

.NET 8: Tracking enable repo-level prebuilt detection dotnet/source-build#3017

Closed

27 tasks

tmat reviewed Jan 9, 2023

View reviewed changes

eng/Versions.props Outdated Show resolved Hide resolved

oleksandr-didyk force-pushed the feat-enable-pre-build-detection branch from fcab584 to c616e6c Compare January 10, 2023 12:22

MichaelSimons reviewed Jan 10, 2023

View reviewed changes

eng/Version.Details.xml Outdated Show resolved Hide resolved

MichaelSimons reviewed Jan 11, 2023

View reviewed changes

eng/cibuild.sh Outdated Show resolved Hide resolved

oleksandr-didyk force-pushed the feat-enable-pre-build-detection branch from c6134d4 to f0df3de Compare January 31, 2023 12:12

oleksandr-didyk mentioned this pull request Feb 1, 2023

[main] Update dependencies from dotnet/arcade #936

Merged

oleksandr-didyk force-pushed the feat-enable-pre-build-detection branch from f0df3de to a2e7374 Compare April 11, 2023 10:50

oleksandr-didyk requested review from MichaelSimons and tmat April 11, 2023 10:55

oleksandr-didyk commented Apr 11, 2023

View reviewed changes

eng/SourceBuildPrebuiltBaseline.xml Outdated Show resolved Hide resolved

MichaelSimons reviewed Apr 11, 2023

View reviewed changes

eng/Version.Details.xml Show resolved Hide resolved

eng/SourceBuildPrebuiltBaseline.xml Outdated Show resolved Hide resolved

MichaelSimons mentioned this pull request Apr 11, 2023

Offline CI legs started failing because of prebuilts dotnet/source-build#3367

Closed

tmat reviewed Apr 13, 2023

View reviewed changes

eng/Versions.props Outdated Show resolved Hide resolved

oleksandr-didyk force-pushed the feat-enable-pre-build-detection branch from 9e2f00b to 02f5032 Compare April 13, 2023 09:35

ViktorHofer mentioned this pull request Apr 15, 2023

Upgrade to net6.0 and remove unused dependencies #1001

Merged

ViktorHofer reviewed Apr 18, 2023

View reviewed changes

NuGet.config Outdated Show resolved Hide resolved

ViktorHofer reviewed Apr 18, 2023

View reviewed changes

eng/SourceBuildPrebuiltBaseline.xml Outdated Show resolved Hide resolved

oleksandr-didyk force-pushed the feat-enable-pre-build-detection branch 3 times, most recently from c9d7ba3 to 99d65a8 Compare May 4, 2023 14:38

oleksandr-didyk requested a review from MichaelSimons May 4, 2023 14:39

oleksandr-didyk requested a review from tmat May 4, 2023 14:39

ViktorHofer reviewed May 4, 2023

View reviewed changes

oleksandr-didyk added 9 commits May 15, 2023 16:04

add pre-build detection

8ce220b

downgrade MSBuild to 16.8

bcc159d

add clarifying comments; move source-build RID prop in CI

583813e

fixup sbrp definition; fixup invalid msbuild version prop

8218b06

update changes made

db472d5

remove redundant CI arg

05bc0df

add missing sb attribute; bump arcade dep versions

89694bc

remove obsolete pre-built exclusions; fixup dep versions

b8fef1f

remove obsolete nuget source; fixup sourcebuild metadata

81716f5

oleksandr-didyk force-pushed the feat-enable-pre-build-detection branch from d790a53 to 81716f5 Compare May 15, 2023 16:08

oleksandr-didyk added 2 commits May 15, 2023 16:13

fixup duplicate dependency declaration

c6ba833

add explanation for dotnet-sourcelink exclusion

0b09480

tmat approved these changes May 16, 2023

View reviewed changes

tmat merged commit d6c5a50 into dotnet:main May 16, 2023

dependabot bot mentioned this pull request Jul 29, 2025

Bump coverlet.collector and 14 others MyIntelligenceAgency/semantic-fleet#54

Open

dependabot bot mentioned this pull request Aug 11, 2025

Bump Microsoft.SourceLink.GitHub from 1.1.1 to 8.0.0 Xkonti/smart-migrations-net#11

Merged

add source-build pre-built detection #933

add source-build pre-built detection #933

Uh oh!

Conversation

oleksandr-didyk commented Jan 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KalleOlaviNiemitalo commented Jan 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mthalman commented Apr 10, 2023

Uh oh!

oleksandr-didyk commented Apr 11, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ViktorHofer commented Apr 18, 2023

Uh oh!

ViktorHofer May 4, 2023

Choose a reason for hiding this comment

Uh oh!

oleksandr-didyk May 4, 2023

Choose a reason for hiding this comment

Uh oh!

tmat May 15, 2023

Choose a reason for hiding this comment

Uh oh!

oleksandr-didyk May 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ViktorHofer May 15, 2023

Choose a reason for hiding this comment

Uh oh!

oleksandr-didyk May 16, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

oleksandr-didyk commented Jan 2, 2023 •

edited

Loading

KalleOlaviNiemitalo commented Jan 2, 2023 •

edited

Loading

oleksandr-didyk May 15, 2023 •

edited

Loading