-
Notifications
You must be signed in to change notification settings - Fork 132
Fix target Input Output as to not interfere with incremental. #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the fix. Would you mind updating the targets files of other providers (GitLab, etc.)? |
@tmat, I am not able to locate this file on GitLab? Is GitHub the main hub for this project? |
@yuehuang010 I think @tmat means the other copies of targets like this, of which there are several: https://github.com/search?q=repo%3Adotnet%2Fsourcelink%20%22%7C%25(Identity)%7C%22&type=code |
@yuehuang010 Thanks! |
Updated [Microsoft.SourceLink.GitHub](https://github.com/dotnet/sourcelink) from 1.1.1 to 8.0.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.SourceLink.GitHub's releases](https://github.com/dotnet/sourcelink/releases)._ ## 8.0.0 ## What's Changed **Source Link is now included in .NET SDK 8 and enabled by default. Projects that migrate to .NET SDK 8 do not need to reference Source Link packages explicitly via `PackageReference` anymore.** * Add sparse checkout support by @pakrym in dotnet/sourcelink#772 * Add support for Gitee by @luocs in dotnet/sourcelink#922 * Fix target Input Output as to not interfere with incremental. by @yuehuang010 in dotnet/sourcelink#901 * Prepare for inclusion in .NET SDK by @tmat in dotnet/sourcelink#988 * Avoid creating source link .json file when no source control mapping is available by @tmat in dotnet/sourcelink#989 * Do not report warnings when SourceLink packages are not referenced ex… by @tmat in dotnet/sourcelink#991 * Bump version to 8.0 to match SDK by @tmat in dotnet/sourcelink#992 * Fix FileWrites by @tmat in dotnet/sourcelink#995 * Remove unnecessary <?xml tags by @ViktorHofer in dotnet/sourcelink#1013 * Remove unnecessary license header in msbuild by @ViktorHofer in dotnet/sourcelink#1014 * Allow multiple Source Link assemblies to be loaded from different locations by @tmat in dotnet/sourcelink#1034 * New command-line APIs and `offline` argument by @NikolaMilosavljevic in dotnet/sourcelink#1068 * Do not report warning if submodule dir is missing by @tmat in dotnet/sourcelink#1078 ## New Contributors * @MichaelSimons made their first contribution in dotnet/sourcelink#836 * @alexperovich made their first contribution in dotnet/sourcelink#867 * @ShreyasJejurkar made their first contribution in dotnet/sourcelink#892 * @pakrym made their first contribution in dotnet/sourcelink#772 * @IanKemp made their first contribution in dotnet/sourcelink#889 * @luocs made their first contribution in dotnet/sourcelink#922 * @yuehuang010 made their first contribution in dotnet/sourcelink#901 * @NikolaMilosavljevic made their first contribution in dotnet/sourcelink#994 * @oleksandr-didyk made their first contribution in dotnet/sourcelink#933 * @v-chayan made their first contribution in dotnet/sourcelink#1054 **Full Changelog**: dotnet/sourcelink@1.1.1...8.0.0 Commits viewable in [compare view](dotnet/sourcelink@1.1.1...8.0.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xkonti <[email protected]>
Fix a Target's Input Output as to not interfere with incremental detection.