Trim away netframework targets in source-build #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last repo for dotnet/source-build#3014 |
MichaelSimons
approved these changes
Apr 10, 2023
mmitche
approved these changes
Apr 10, 2023
|
@tmat any concerns with merging this? (I do not have permissions.) This is a source-build only change. All checks are passing. |
Xkonti
added a commit
to Xkonti/smart-migrations-net
that referenced
this pull request
Aug 13, 2025
Updated [Microsoft.SourceLink.GitHub](https://github.com/dotnet/sourcelink) from 1.1.1 to 8.0.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.SourceLink.GitHub's releases](https://github.com/dotnet/sourcelink/releases)._ ## 8.0.0 ## What's Changed **Source Link is now included in .NET SDK 8 and enabled by default. Projects that migrate to .NET SDK 8 do not need to reference Source Link packages explicitly via `PackageReference` anymore.** * Add sparse checkout support by @pakrym in dotnet/sourcelink#772 * Add support for Gitee by @luocs in dotnet/sourcelink#922 * Fix target Input Output as to not interfere with incremental. by @yuehuang010 in dotnet/sourcelink#901 * Prepare for inclusion in .NET SDK by @tmat in dotnet/sourcelink#988 * Avoid creating source link .json file when no source control mapping is available by @tmat in dotnet/sourcelink#989 * Do not report warnings when SourceLink packages are not referenced ex… by @tmat in dotnet/sourcelink#991 * Bump version to 8.0 to match SDK by @tmat in dotnet/sourcelink#992 * Fix FileWrites by @tmat in dotnet/sourcelink#995 * Remove unnecessary <?xml tags by @ViktorHofer in dotnet/sourcelink#1013 * Remove unnecessary license header in msbuild by @ViktorHofer in dotnet/sourcelink#1014 * Allow multiple Source Link assemblies to be loaded from different locations by @tmat in dotnet/sourcelink#1034 * New command-line APIs and `offline` argument by @NikolaMilosavljevic in dotnet/sourcelink#1068 * Do not report warning if submodule dir is missing by @tmat in dotnet/sourcelink#1078 ## New Contributors * @MichaelSimons made their first contribution in dotnet/sourcelink#836 * @alexperovich made their first contribution in dotnet/sourcelink#867 * @ShreyasJejurkar made their first contribution in dotnet/sourcelink#892 * @pakrym made their first contribution in dotnet/sourcelink#772 * @IanKemp made their first contribution in dotnet/sourcelink#889 * @luocs made their first contribution in dotnet/sourcelink#922 * @yuehuang010 made their first contribution in dotnet/sourcelink#901 * @NikolaMilosavljevic made their first contribution in dotnet/sourcelink#994 * @oleksandr-didyk made their first contribution in dotnet/sourcelink#933 * @v-chayan made their first contribution in dotnet/sourcelink#1054 **Full Changelog**: dotnet/sourcelink@1.1.1...8.0.0 Commits viewable in [compare view](dotnet/sourcelink@1.1.1...8.0.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xkonti <[email protected]>
This was referenced Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
This is part of the source-build work to enable trimming of net4* targets. Parent repos (
installerandsdk) have been updated, so the next step is to update dependencies, likesourcelink.Here's how this is consumed: dotnet/arcade#12785
Top-level tracking issue: dotnet/source-build#3014
This essentially just avoids building net4* TFMs when building Linux source build.
Fixes: #868