[main] Update dependencies from dotnet/arcade

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

• Subscription: fd62beb8-99ae-4af6-3912-08d8e9750bf8
• Build: 20230318.1
• Date Produced: March 18, 2023 4:56:46 PM UTC
• Commit: b12f035e893c34ec2c965d75f6e21b7a2667e98d
• Branch: refs/heads/main

• Updates:
  • Microsoft.DotNet.Arcade.Sdk: from 8.0.0-beta.22630.1 to 8.0.0-beta.23168.1

[oleksandr-didyk]

@tmat pinging you here as a notice that the changes that are being flown-in with this Maestro PR are also affecting the #933 PR. Specifically:

• the new Arcade version has new functionality that would allow better UX for source-building the repo in CI and locally
• the PR for pre-built detection bumps the System.Text.Json version to latest, which in turn requires an undesirable warning suppression for targeting < net8.0

I would guess the best course of action would be to update sourcelink to target latest tfm. Could you please let me know if, in your opinion, that's the right choice in this context and if this work will be done by your or by someone else. Thanks!

[tmat]

@oleksandr-didyk

I tried to update net7.0 TFMs to $(NetCurrent), which should be net8.0 now.

I get the following error though:

D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102: Unable to find package Microsoft.WindowsDesktop.App.Runtime.win-x64 with version (= 8.0.0-alpha.1.23057.1) [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 110 version(s) in dotnet-public [ Nearest version: 8.0.0-preview.1.23112.2 ] [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 0 version(s) in dotnet-eng [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 0 version(s) in dotnet-tools [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102: Unable to find package Microsoft.WindowsDesktop.App.Runtime.win-x86 with version (= 8.0.0-alpha.1.23057.1) [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 110 version(s) in dotnet-public [ Nearest version: 8.0.0-preview.1.23112.2 ] [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 0 version(s) in dotnet-eng [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 0 version(s) in dotnet-tools [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.App.Runtime.win-x64 with version (= 8.0.0-alpha.1.23058.7) [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 113 version(s) in dotnet-public [ Nearest version: 8.0.0-preview.1.23112.2 ] [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 1 version(s) in dotnet-tools [ Nearest version: 5.0.0-rc.2.20513.11 ] [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 0 version(s) in dotnet-eng [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.App.Runtime.win-x86 with version (= 8.0.0-alpha.1.23058.7) [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 113 version(s) in dotnet-public [ Nearest version: 8.0.0-preview.1.23112.2 ] [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 1 version(s) in dotnet-tools [ Nearest version: 5.0.0-rc.2.20513.11 ] [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 0 version(s) in dotnet-eng [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.App.Runtime.osx-x64 with version (= 8.0.0-alpha.1.23058.7) [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 112 version(s) in dotnet-public [ Nearest version: 8.0.0-preview.1.23112.2 ] [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 1 version(s) in dotnet-tools [ Nearest version: 5.0.0-rc.2.20513.11 ] [D:\sourcelink\SourceLink.sln]
D:\sourcelink\src\dotnet-sourcelink\dotnet-sourcelink.csproj : error NU1102:   - Found 0 version(s) in dotnet-eng [D:\sourcelink\SourceLink.sln]

[oleksandr-didyk]

Those packages are coming from the dotnet8 feed, so you would need to add it to the NuGet.config

You can always find these assets yourself through the Darc CL tool -> https://github.com/dotnet/arcade/blob/main/Documentation/Darc.md

For example, here is how I found which NuGet feed is missing:

darc get-asset --name "Microsoft.AspNetCore.App.Runtime.win-x64" --version "8.0.0-alpha.1.23058.7" --max-age 60

with the output:

Looking up assets with name 'Microsoft.AspNetCore.App.Runtime.win-x64' and version '8.0.0-alpha.1.23058.7' in the last 60 days
Microsoft.AspNetCore.App.Runtime.win-x64 @ 8.0.0-alpha.1.23058.7
Repository:    https://github.com/dotnet/aspnetcore
Branch:        main
Commit:        cefc6ccf4b23ac9f07418cd10e374cf533276eee
Build Number:  20230108.7
Date Produced: 1/9/2023 1:58 AM
Build Link:    https://dev.azure.com/dnceng/internal/_build/results?buildId=2082781
AzDO Build Id: 2082781
BAR Build Id:  162010
Released:      False
Channels:
- .NET 8
Locations:
- https://dev.azure.com/dnceng/internal/_apis/build/builds/2082781/artifacts (Container)
- https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json (NugetFeed)

[tmat]

Shouldn't Arcade automatically update nuget.config and add the right feed when bumping to new .NET version? Seems like the goals is to automate bumping versions as much as possible. While setting $(CurrentNet) to net8.0 addresses that for TFM it will still need manual intervention unless nuget.config is also updated automatically.

[mmitche]

Shouldn't Arcade automatically update nuget.config and add the right feed when bumping to new .NET version? Seems like the goals is to automate bumping versions as much as possible. While setting $(CurrentNet) to net8.0 addresses that for TFM it will still need manual intervention unless nuget.config is also updated automatically.

Arcade does not update any set of feeds except for stable package dependency flow.

[mmitche]

@tmat Is the netcoreapp3.1 target still intended in this repo, since it's EOL now?

[oleksandr-didyk]

@tmat - I apologize for the ping, but would you have any update on the progress for this PR? Or maybe there is something that we can help with to push it further? Thank you!

[tmat]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[tmat]

@oleksandr-didyk @mmitche Seems to be mostly working now. Some source build issue.

[oleksandr-didyk]

The failure happens both in normal and source-build and seems to be related to this change -> e7788ce (#936)

The TFM default var is probably wrong - instead of $(CurrentNet) it should be $(NetCurrent) (https://github.com/dotnet/arcade/blob/8bbaaa29ff764792da8518d2ad708ee4dd3cf3d5/src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkDefaults.props#L17) just like in other projects

[tmat]

@oleksandr-didyk Oh, thanks! Fixing.