Skip to content

ARROW-17645: [CI] Get conda-integration building again #14069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 4 commits into from
Sep 13, 2022
Merged

ARROW-17645: [CI] Get conda-integration building again #14069

kou merged 4 commits into from
Sep 13, 2022

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Sep 7, 2022

No description provided.

@lidavidm lidavidm mentioned this pull request Sep 7, 2022
Merged
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

https://issues.apache.org/jira/browse/ARROW-17645

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

⚠️ Ticket has no components in JIRA, make sure you assign one.

@lidavidm lidavidm mentioned this pull request Sep 7, 2022
Merged
@lidavidm lidavidm marked this pull request as ready for review September 7, 2022 22:14
@zeroshade zeroshade mentioned this pull request Sep 8, 2022
Merged
@lidavidm
Copy link
Member Author

lidavidm commented Sep 9, 2022

@kou or @assignUser, how does this look for a fix? I'm not happy about pinning more things but it seems zlib hasn't made a new release yet

@kou
Copy link
Member

kou commented Sep 9, 2022 •
edited
Loading

Can we apply madler/zlib@ec3df00 in https://github.com/conda-forge/zlib-feedstock instead?

@lidavidm
Copy link
Member Author

lidavidm commented Sep 10, 2022

I'll try opening a PR and seeing if there's interest in patching

@lidavidm lidavidm mentioned this pull request Sep 10, 2022
Merged
@lidavidm
Copy link
Member Author

lidavidm commented Sep 12, 2022

conda-forge/zlib-feedstock#66

@lidavidm
Copy link
Member Author

lidavidm commented Sep 12, 2022

Patch was accepted, so once I see the new packages go out I'll test unpinning the dependency

@lidavidm
Copy link
Member Author

lidavidm commented Sep 12, 2022

Hmm, it failed, but I see it didn't install the most updated zlib…trying again

@lidavidm
Copy link
Member Author

lidavidm commented Sep 12, 2022

Looks like a dummy change to bump the cache did the trick - what's the 'right' way to accomplish that?

@kou
Copy link
Member

kou commented Sep 13, 2022

I'll remove the cached images listed at https://hub.docker.com/r/apache/arrow-dev/tags (admin page: https://hub.docker.com/repository/docker/apache/arrow-dev/tags ).

@kou
Copy link
Member

kou commented Sep 13, 2022

I've removed amd64-conda and amd64-conda-cpp.

@lidavidm
Revert "bump the cache?"
fad39d8 
This reverts commit ffe60a2.
@lidavidm
Copy link
Member Author

lidavidm commented Sep 13, 2022

Thanks! Reverted the last commit, let's see how the build goes now

kou
kou approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit ef8cb09 into apache:master Sep 13, 2022
@lidavidm lidavidm deleted the arrow-17645 branch September 13, 2022 11:35
@ursabot
Copy link

ursabot commented Sep 13, 2022

Benchmark runs are scheduled for baseline = e0ed269 and contender = ef8cb09. ef8cb09 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.61% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️2.2% ⬆️0.53%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] ef8cb099 ec2-t3-xlarge-us-east-2
[Finished] ef8cb099 test-mac-arm
[Failed] ef8cb099 ursa-i9-9960x
[Finished] ef8cb099 ursa-thinkcentre-m75q
[Finished] e0ed2697 ec2-t3-xlarge-us-east-2
[Failed] e0ed2697 test-mac-arm
[Failed] e0ed2697 ursa-i9-9960x
[Finished] e0ed2697 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@lidavidm @zagto
ARROW-17645: [CI] Get conda-integration building again (apache#14069)
50369be 
Authored-by: David Li <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@asfimport asfimport mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lidavidm @kou @ursabot