Skip to content

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Sep 9, 2022

/arrow/cpp/src/arrow/compute/exec/bloom_filter.h:252:25: error: type attributes ignored after type is already defined [-Werror=attributes]
  252 | enum class ARROW_EXPORT BloomFilterBuildStrategy {
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you beat me to it.

@lidavidm
Copy link
Member Author

UBSAN failure: ARROW-17675

R failures: I think that's the DuckDB issue

Integration: #14069, though I guess I have to go try patching zlib now

@lidavidm lidavidm merged commit 8a9037d into apache:master Sep 10, 2022
@ursabot
Copy link

ursabot commented Sep 11, 2022

Benchmark runs are scheduled for baseline = f184255 and contender = 8a9037d. 8a9037d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.02% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.63% ⬆️0.11%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8a9037d4 ec2-t3-xlarge-us-east-2
[Failed] 8a9037d4 test-mac-arm
[Failed] 8a9037d4 ursa-i9-9960x
[Finished] 8a9037d4 ursa-thinkcentre-m75q
[Finished] f184255c ec2-t3-xlarge-us-east-2
[Failed] f184255c test-mac-arm
[Failed] f184255c ursa-i9-9960x
[Finished] f184255c ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
```
/arrow/cpp/src/arrow/compute/exec/bloom_filter.h:252:25: error: type attributes ignored after type is already defined [-Werror=attributes]
  252 | enum class ARROW_EXPORT BloomFilterBuildStrategy {
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~
```

Authored-by: David Li <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants