Skip to content

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Sep 6, 2022

Otherwise a minimal build fails with errors like

CMake Error at cmake_modules/BuildUtils.cmake:272 (target_link_libraries):
  Target "arrow_testing_objlib" links to:

    rapidjson::rapidjson

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  src/arrow/CMakeLists.txt:653 (add_arrow_lib)

@lidavidm lidavidm marked this pull request as ready for review September 6, 2022 19:46
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Good catch!

@lidavidm lidavidm force-pushed the minor-testing-rapidjson branch from ebff30c to 2db8d96 Compare September 7, 2022 20:51
@lidavidm
Copy link
Member Author

lidavidm commented Sep 7, 2022

Integration test is failing, see #14069

@lidavidm lidavidm merged commit 8fe7e35 into apache:master Sep 8, 2022
@lidavidm lidavidm deleted the minor-testing-rapidjson branch September 8, 2022 14:02
@ursabot
Copy link

ursabot commented Sep 8, 2022

Benchmark runs are scheduled for baseline = 2920d52 and contender = 8fe7e35. 8fe7e35 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.34% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.82% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.07% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8fe7e353 ec2-t3-xlarge-us-east-2
[Finished] 8fe7e353 test-mac-arm
[Failed] 8fe7e353 ursa-i9-9960x
[Finished] 8fe7e353 ursa-thinkcentre-m75q
[Finished] 2920d52d ec2-t3-xlarge-us-east-2
[Finished] 2920d52d test-mac-arm
[Failed] 2920d52d ursa-i9-9960x
[Finished] 2920d52d ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
Otherwise a minimal build fails with errors like

```
CMake Error at cmake_modules/BuildUtils.cmake:272 (target_link_libraries):
  Target "arrow_testing_objlib" links to:

    rapidjson::rapidjson

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  src/arrow/CMakeLists.txt:653 (add_arrow_lib)
```

Authored-by: David Li <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants