[UI] Edit Cluster #1400
Merged
[UI] Edit Cluster #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into edit-cluster
…erprise into edit-cluster
…erprise into edit-cluster
…into edit-cluster
…erprise into edit-cluster
…erprise into edit-cluster
- Update local form representation from UpdatedProfile[] to a map of { [name: string}: UpdatedProfile } for easier updates of state.
- Moves parameter_values into formData.parameter_values to avoid accidentally loading head_branch etc back into the form state from the annotation.
- Fixes ProfilesContext `isLoading` and `profiles` being out of sync (rm onSuccess handler)
- Remove activeCluster / activeTemplate, just read from URL
- Remove local setSelected state from Profiles component, handle all state in ClusterForm
- Pull out a few helper functions like
- toPayload
- getInitialData
foot
approved these changes
Sep 6, 2022
This was referenced Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1393
Closes #1450
isLoadingandprofilesbeing out of sync (rm the onSuccess handler and wrap the post-request transformations in a useMemo instead)