Skip to content

empty clusterAutomation array so that you can only add application if … you want to and omit empty kustomizations for create cluster payload #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

ahussein3
Copy link
Contributor

@ahussein3 ahussein3 commented Aug 24, 2022

Fixes #1352

… you want to and omit empty kustomizations for create cluster payload
@ahussein3 ahussein3 requested a review from foot August 24, 2022 12:12
@ahussein3 ahussein3 added the bug Something isn't working label Aug 24, 2022
@ahussein3 ahussein3 requested a review from foot August 24, 2022 13:09
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ahussein3 ahussein3 merged commit 033a63a into main Aug 24, 2022
@ahussein3 ahussein3 deleted the UI-1352-omitEmptyApplicationFromCreateClusterPayload branch August 24, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] CAPI cluster PR cannot be created without specifying default Application
2 participants