Skip to content

empty clusterAutomation array so that you can only add application if … you want to and omit empty kustomizations for create cluster payload #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2022
Merged

empty clusterAutomation array so that you can only add application if … you want to and omit empty kustomizations for create cluster payload #1355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed466a7
empty clusterAutomation array so that you can only add application if…
ahussein3 Aug 24, 2022
e3341dd
adding trim to remove unintended spaces
ahussein3 Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ui-cra/src/components/Clusters/Create/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ const AddCluster: FC = () => {
pullRequestTitle: 'Creates cluster',
commitMessage: 'Creates capi cluster',
pullRequestDescription: 'This PR creates a new cluster',
clusterAutomations: [{ name: '', namespace: '', path: '' }],
clusterAutomations: [],
};

let initialProfiles = [] as UpdatedProfile[];
Expand Down Expand Up @@ -213,7 +213,12 @@ const AddCluster: FC = () => {

const handleAddCluster = useCallback(() => {
const { clusterAutomations, ...rest } = formData;
const kustomizations = clusterAutomations.map(
// filter out empty kustomization
const filteredKustomizations = clusterAutomations.filter(
(kustomization: any) =>
Object.values(kustomization).join('').trim() !== '',
);
const kustomizations = filteredKustomizations.map(
(kustomization: any): Kustomization => {
return {
metadata: {
Expand Down