fix(Fabric,Android): header subviews do not support dynamic content changes #2910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This call seems to be currently unnecessary - `TestHeaderTitle` & `Test2466` do keep working. Removing that call gets rid of the source* of the issue, as described in PR description. * this is not the real real source. IMHO the real one is lack of support for native layout in React Native, however this won't be improved anytime soon.
Member
Author
|
Found following regression: bug-found-while-testing-new-solution-android.movwhat's kinda funny - it seems to happen ONLY with react native built from source. This is unrelated to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2714 on Android
Fixes #2815 on Android
See #2905 for detailed description.
Changes
Removed call to
RNSScreenStaceaderSubviewShadowNode.setSizein corresponding component descriptor.It seems that we do not need to enforce node size from HostTree. Setting appropriate content offset is enough for pressables to function correctly (assuming that native layout does not change size of any subview). I currently can't come up with any scenario where this would happen.
Test code and steps to reproduce
I've tested:
Test2714introduced in PR with iOS fixes - fix(Fabric,iOS): header subviews do not support dynamic content changes #2905TestHeaderTitlewith call tosetOptionsinuseLayoutEffect)Test2811- fix(Android,Fabric): prevent Yoga from stretch-fitting height of header subview #2811setOptions#2812 (with snippet provided in that PR description)Checklist