Commit 0e2fd32
authored
fix(Fabric,Android): header subviews do not support dynamic content changes (#2910)
## Description
Fixes
#2714 on
Android
Fixes
#2815 on
Android
See #2905 for detailed description.
## Changes
Removed call to `RNSScreenStaceaderSubviewShadowNode.setSize` in
corresponding component descriptor.
It seems that we do not need to enforce node size from HostTree. Setting
appropriate content offset is enough for pressables to function
correctly (assuming that native layout **does not change size of any
subview**). I currently can't come up with any scenario where this would
happen.
## Test code and steps to reproduce
I've tested:
* [x] `Test2714` introduced in PR with iOS fixes -
#2905
* [x] Pressables in header -
#2466,
* [x] Header title truncation -
#2325 (only
few cases, as the list is long there) & noticed a regression (not
related to this PR, described in comment below the PR description),
* [x] Insets with orientation change (Android) -
#2756
* [x] #2807
(on `TestHeaderTitle` with call to `setOptions` in `useLayoutEffect`)
* [x] `Test2811` -
#2811
* [x] #2812
(with snippet provided in that PR description)
## Checklist
- [x] Included code example that can be used to test this change
- [x] Ensured that CI passes1 parent ad24734 commit 0e2fd32
File tree
1 file changed
+3
-20
lines changed- common/cpp/react/renderer/components/rnscreens
1 file changed
+3
-20
lines changedLines changed: 3 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
43 | 26 | | |
44 | 27 | | |
45 | 28 | | |
| |||
0 commit comments