Skip to content

fix(Fabric,Android): header subviews do not support dynamic content changes #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkafar merged 1 commit into from
May 8, 2025
Merged

fix(Fabric,Android): header subviews do not support dynamic content changes #2910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions .../cpp/react/renderer/components/rnscreens/RNSScreenStackHeaderSubviewComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,26 +20,9 @@ class RNSScreenStackHeaderSubviewComponentDescriptor final
using ConcreteComponentDescriptor::ConcreteComponentDescriptor;

void adopt(ShadowNode &shadowNode) const override {
#ifdef ANDROID
react_native_assert(
dynamic_cast<RNSScreenStackHeaderSubviewShadowNode *>(&shadowNode));
auto &subviewShadowNode =
static_cast<RNSScreenStackHeaderSubviewShadowNode &>(shadowNode);

react_native_assert(
dynamic_cast<YogaLayoutableShadowNode *>(&subviewShadowNode));
auto &layoutableShadowNode =
dynamic_cast<YogaLayoutableShadowNode &>(subviewShadowNode);

auto state = std::static_pointer_cast<
const RNSScreenStackHeaderSubviewShadowNode::ConcreteState>(
shadowNode.getState());
auto stateData = state->getData();

if (!isSizeEmpty(stateData.frameSize)) {
layoutableShadowNode.setSize(stateData.frameSize);
}
#endif
// Note: Be very careful with calling `shadowNode.setSize` here. By doing
// that, you are likely to introduce a regressions on both platforms. See:
// https://github.com/software-mansion/react-native-screens/pull/2905

ConcreteComponentDescriptor::adopt(shadowNode);
}
Expand Down
Loading