Fix incorrect VC default HTTP token path when the --datadir flag is present
#6748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
bug
jimmygchen
force-pushed
the
fix-api-token-path
branch
from
0a9b7dc to
3e8935b
Compare
jimmygchen
force-pushed
the
fix-api-token-path
branch
from
3e8935b to
eeb3916
Compare
|
This wasn't included in the v6.0.1 release, so a patch isn't required 😌 |
jimmygchen
added
ready-for-review
pawanjay176
approved these changes
Jan 8, 2025
pawanjay176
added
ready-for-merge
|
@mergify requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 87b72de |
This was referenced Jan 8, 2025
|
Thanks for catching this! I made a mistake in my previous contribution, and I appreciate your help in fixing it. |
|
All good, I missed it in review too 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fixes a validator client bug introduced in #6577.
When a custom
--datadirflag is provided, the default http token path changes to$HOME/.lighthouse/mainnet/validators/api-token.txt, rather than the previous default<datadir>/validators/api-token.txtThis causes a
CRITin some setups where the validator client does not have write access to the home directory (e.g.eth-docker):Proposed Changes
Set the correct default VC API token path, if a
datadirorvalidators-diris provided.