Skip to content

Fix incorrect data column metric name #6761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix incorrect data column metric name #6761

merged 1 commit into from
Jan 8, 2025

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Fixes incorrect data column metric name.

@jimmygchen jimmygchen added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! das Data Availability Sampling labels Jan 7, 2025
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 7, 2025
@jimmygchen
Copy link
Member Author

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jan 7, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The pull request #6761 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen jimmygchen force-pushed the fix-das-metric-name branch from f609330 to bf9fdac Compare January 8, 2025 00:52
@jimmygchen
Copy link
Member Author

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Jan 8, 2025

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@jimmygchen
Copy link
Member Author

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jan 8, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 80cfbea

mergify bot added a commit that referenced this pull request Jan 8, 2025
@mergify
Merge of #6761
5e5be11
This was referenced Jan 8, 2025
Closed
Merged
Merged
@mergify mergify bot merged commit 80cfbea into sigp:unstable Jan 8, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
das Data Availability Sampling low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmygchen @dapplion