Ensure that elixir escript does not read from stdin #10108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
lukebakken/figure-out-rabbitmqctl-stdin
branch
2 times, most recently
from
9ab2e63 to
a73031c
Compare
lukebakken
force-pushed
the
lukebakken/figure-out-rabbitmqctl-stdin
branch
from
a73031c to
910e0df
Compare
lukebakken
added a commit
to lukebakken/misc
that referenced
this pull request
Dec 12, 2023
|
To test, use this shell script: https://github.com/lukebakken/misc/blob/main/sh/add_users.sh You'll have to adjust the path to Without the changes in this PR, only the first user will be added from This is the reason why - https://stackoverflow.com/a/13800476/1466825 It took quite a bit of trial-and-error to figure out how to correctly pass |
lukebakken
force-pushed
the
lukebakken/figure-out-rabbitmqctl-stdin
branch
5 times, most recently
from
dc5026f to
761d592
Compare
lukebakken
force-pushed
the
lukebakken/figure-out-rabbitmqctl-stdin
branch
from
6e690f3 to
12bb6a1
Compare
lukebakken
added a commit
that referenced
this pull request
Dec 13, 2023
Discovered while testing #10108 by using the lukebakken/docker-rabbitmq-cluster project. That project, by default, uses longnames for node names. When testing classic peer discovery, starting a peer node would time out every time.
lukebakken
force-pushed
the
lukebakken/figure-out-rabbitmqctl-stdin
branch
from
21e8de4 to
9c05a43
Compare
lukebakken
added a commit
that referenced
this pull request
Dec 13, 2023
Discovered while testing #10108 by using the lukebakken/docker-rabbitmq-cluster project. That project, by default, uses longnames for node names. When testing classic peer discovery, starting a peer node would time out every time. Ensure `host` is set
lukebakken
added a commit
that referenced
this pull request
Dec 13, 2023
Discovered while testing #10108 by using the lukebakken/docker-rabbitmq-cluster project. That project, by default, uses longnames for node names. When testing classic peer discovery, starting a peer node would time out every time. Ensure `host` is set
lukebakken
force-pushed
the
lukebakken/figure-out-rabbitmqctl-stdin
branch
from
9c05a43 to
77295d5
Compare
lukebakken
added a commit
that referenced
this pull request
Dec 14, 2023
Discovered while testing #10108 by using the lukebakken/docker-rabbitmq-cluster project. That project, by default, uses longnames for node names. When testing classic peer discovery, starting a peer node would time out every time. Ensure `host` is set
This change ensures that you do not have to redirect `stdin` from `/dev/null` to use `rabbitmqctl` and related utilities in a `while` / `read` shell loop. References: * https://github.com/lukebakken/vesc-1073/blob/main/delete.bash#L24-L32 * rabbitmq/support-tools#38
lukebakken
force-pushed
the
lukebakken/figure-out-rabbitmqctl-stdin
branch
from
77295d5 to
cb28ffc
Compare
|
This does work as expected but I had to build a generic UNIX package in order to observe the difference. Bazel-build |
michaelklishin
approved these changes
Dec 14, 2023
I had to remove the contents of the generated |
michaelklishin
pushed a commit
that referenced
this pull request
Feb 29, 2024
Discovered while testing #10108 by using the lukebakken/docker-rabbitmq-cluster project. That project, by default, uses longnames for node names. When testing classic peer discovery, starting a peer node would time out every time. Ensure `host` is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that you do not have to redirect
stdinfrom/dev/nullto userabbitmqctland related utilities in awhile/readshell loop.References:
TODO: test with inter-node TLS.