Skip to content

Ensure peer:start/1 takes long names into account #10135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

lukebakken
Copy link
Collaborator

@lukebakken lukebakken commented Dec 13, 2023

Discovered while testing
#10108 by using the lukebakken/docker-rabbitmq-cluster project.

That project, by default, uses longnames for node names. When testing classic peer discovery, starting a peer node would time out every time.

@lukebakken lukebakken self-assigned this Dec 13, 2023
@lukebakken lukebakken force-pushed the lukebakken/fix-peer-start-longnames branch 2 times, most recently from f15c95c to 9a91900 Compare December 13, 2023 22:41
@lukebakken lukebakken marked this pull request as ready for review December 13, 2023 22:42
@lukebakken
Copy link
Collaborator Author

Test Procedure

Environment - Ubuntu 22 with Docker

Setup:

git clone https://github.com/lukebakken/docker-rabbitmq-cluster.git

Fails

cd docker-rabbitmq-cluster
make RABBITMQ_DOCKER_TAG='pivotalrabbitmq/rabbitmq:main-otp-max-bazel' up
...
...
...
BOOT FAILED
===========
Exception during startup:

2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0> BOOT FAILED
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0> ===========
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0> Exception during startup:
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0> exit:timeout
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>     peer:start_it/2, line 646
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>     rabbit_peer_discovery:query_node_props/1, line 383
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>     rabbit_peer_discovery:sync_desired_cluster/3, line 188
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>     rabbit_db:init/0, line 65
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>     rabbit_boot_steps:-run_step/2-lc$^0/1-0-/2, line 51
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>     rabbit_boot_steps:run_step/2, line 58
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>     rabbit_boot_steps:-run_boot_steps/1-lc$^0/1-0-/1, line 22
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>     rabbit_boot_steps:run_boot_steps/1, line 23
2023-12-13 22:44:44.944357+00:00 [error] <0.254.0>
exit:timeout

    peer:start_it/2, line 646
    rabbit_peer_discovery:query_node_props/1, line 383
    rabbit_peer_discovery:sync_desired_cluster/3, line 188
    rabbit_db:init/0, line 65
    rabbit_boot_steps:-run_step/2-lc$^0/1-0-/2, line 51
    rabbit_boot_steps:run_step/2, line 58
    rabbit_boot_steps:-run_boot_steps/1-lc$^0/1-0-/1, line 22
    rabbit_boot_steps:run_boot_steps/1, line 23

Succeeds

make RABBITMQ_DOCKER_TAG='pivotalrabbitmq/rabbitmq:fix-peer-start-longnames-otp-max-bazel' up

Discovered while testing
#10108 by using the
lukebakken/docker-rabbitmq-cluster project.

That project, by default, uses longnames for node names. When testing
classic peer discovery, starting a peer node would time out every time.

Ensure `host` is set
@lukebakken lukebakken force-pushed the lukebakken/fix-peer-start-longnames branch from 9a91900 to d5aaaa9 Compare December 14, 2023 14:12
@michaelklishin michaelklishin merged commit a5ed9d0 into main Dec 14, 2023
@michaelklishin michaelklishin deleted the lukebakken/fix-peer-start-longnames branch December 14, 2023 17:36
@michaelklishin michaelklishin added this to the 3.13.0 milestone Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants