Ensure peer:start/1 takes long names into account

Discovered while testing
#10108 by using the
lukebakken/docker-rabbitmq-cluster project.

That project, by default, uses longnames for node names. When testing
classic peer discovery, starting a peer node would time out every time.

Author: lukebakken

deps/rabbit/src/rabbit_peer_discovery.erl

@@ -356,8 +356,7 @@ check_discovered_nodes_list_validity(DiscoveredNodes, BadNodeType)
 
 query_node_props(Nodes) when Nodes =/= [] ->
     {Prefix, _Suffix} = rabbit_nodes_common:parts(node()),
-    PeerName = lists:flatten(
-                 io_lib:format("~s-peerdisc-~s", [Prefix, os:getpid()])),
+    PeerName = peer:random_name(Prefix),
     %% We go through a temporary hidden node to query all other discovered
     %% peers properties, instead of querying them directly.
     %%
@@ -372,15 +371,20 @@ query_node_props(Nodes) when Nodes =/= [] ->
     %%
     %% By using a temporary intermediate hidden node, we ask Erlang not to
     %% connect everyone automatically.
+    Context = rabbit_prelaunch:get_context(),
     VMArgs0 = ["-hidden"],
-    VMArgs1 = case rabbit_prelaunch:get_context() of
+    VMArgs1 = case Context of
                   #{erlang_cookie := ErlangCookie,
                     var_origins := #{erlang_cookie := environment}} ->
                       ["-setcookie", atom_to_list(ErlangCookie) | VMArgs0];
                   _ ->
                       VMArgs0
               end,
-    case peer:start(#{name => PeerName, args => VMArgs1}) of
+    Longnames = case Context of
+                    #{nodename_type := longnames} -> true;
+                    _ -> false
+                end,
+    case peer:start(#{name => PeerName, longnames => Longnames, args => VMArgs1}) of
         {ok, Pid, Peer} ->
             ?LOG_DEBUG(
                "Peer discovery: use temporary hidden node '~ts' to query "

deps/rabbitmq_prelaunch/src/rabbit_prelaunch_dist.erl

@@ -12,7 +12,7 @@ setup(#{nodename := Node, nodename_type := NameType} = Context) ->
        "~n== Erlang distribution ==", [],
        #{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
     ?LOG_DEBUG(
-       "Rqeuested node name: ~ts (type: ~ts)",
+       "Requested node name: ~ts (type: ~ts)",
        [Node, NameType],
        #{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
     case node() of
@@ -149,5 +149,3 @@ set_credentials_obfuscation_secret() ->
                                    credentials_obfuscation_fallback_secret, 
                                    <<"nocookie">>),
     ok = credentials_obfuscation:set_fallback_secret(Fallback).
-
-