-
Notifications
You must be signed in to change notification settings - Fork 3k
Config Doc - Make sure the Management interface config has a title #48881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc @mcruzdev |
Status for workflow
|
🎊 PR Preview dfe878f has been successfully built and deployed to https://quarkus-pr-main-48881-preview.surge.sh/version/main/guides/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
</path> | ||
</annotationProcessorPaths> | ||
<compilerArgs> | ||
<arg>-AsplitOnConfigRootDescription=true</arg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsmet what this one does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used when an extension has multiple roots. You can either group them or split them.
That being said, I'm not happy with this and I need to revisit it.
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm bit in hurry, so I just quickly checked, seems like splitOnConfigrootDescription
causes existingConfigRoot.merge(configRoot);
which fixed the issue, right? LGTM
Uh oh!
There was an error while loading. Please reload this page.