Skip to content

Config Doc - Make sure the Management interface config has a title #48881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

Config Doc - Make sure the Management interface config has a title #48881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b65de3a
Config Doc - Make sure the Management interface config has a title
gsmet Jul 11, 2025
781a389
Minor cleanup
gsmet Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...rc/main/java/io/quarkus/annotation/processor/documentation/config/merger/ModelMerger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,11 @@ private static String getConfigRootDescription(JavadocRepository javadocReposito
return null;
}

String descriptionCandidate = trimFinalDot(javadocElement.get().description());

if (description == null) {
description = trimFinalDot(javadocElement.get().description());
} else if (!description.equals(trimFinalDot(javadocElement.get().description()))) {
description = descriptionCandidate;
} else if (!description.equals(descriptionCandidate)) {
return null;
}
}
Expand Down
3 changes: 3 additions & 0 deletions extensions/vertx-http/deployment/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@
<version>${project.version}</version>
</path>
</annotationProcessorPaths>
<compilerArgs>
<arg>-AsplitOnConfigRootDescription=true</arg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet what this one does?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used when an extension has multiple roots. You can either group them or split them.

That being said, I'm not happy with this and I need to revisit it.

</compilerArgs>
</configuration>
</execution>
</executions>
Expand Down
3 changes: 3 additions & 0 deletions extensions/vertx-http/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@
<version>${project.version}</version>
</path>
</annotationProcessorPaths>
<compilerArgs>
<arg>-AsplitOnConfigRootDescription=true</arg>
</compilerArgs>
</configuration>
</execution>
</executions>
Expand Down
3 changes: 2 additions & 1 deletion ...http/runtime/src/main/java/io/quarkus/vertx/http/runtime/management/ManagementConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
import io.smallrye.config.WithName;

/**
* Configures the management interface.
* Management interface.
* <p>
* Note that the management interface must be enabled using the
* {@link ManagementInterfaceBuildTimeConfig#enabled} build-time property.
*/
Expand Down
2 changes: 1 addition & 1 deletion ...ain/java/io/quarkus/vertx/http/runtime/management/ManagementInterfaceBuildTimeConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import io.vertx.core.http.ClientAuth;

/**
* Management interface configuration.
* Management interface.
*/
@ConfigMapping(prefix = "quarkus.management")
@ConfigRoot(phase = ConfigPhase.BUILD_AND_RUN_TIME_FIXED)
Expand Down
Loading