Skip to content

CONSOLE-4619: Create ExternalLinkButton component and use it #15177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Jun 17, 2025
Merged

CONSOLE-4619: Create ExternalLinkButton component and use it #15177

openshift-merge-bot merged 3 commits into from
Jun 17, 2025

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Jun 12, 2025 •
edited
Loading

fixes https://issues.redhat.com/browse/CONSOLE-4619

BREAKING: this PR removes co-external-link

after new ExternalLinkWithCopy design:
image

after new ExternalLink:
image

tech debt, adding labels:
/label docs-approved
/label px-approved

/hold for prereq PR #15081

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 12, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4619 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

fixes https://issues.redhat.com/browse/CONSOLE-4619

BREAKING: this PR removes co-external-link

tech debt, adding labels:
/label docs-approved
/label px-approved

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 12, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4619 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

fixes https://issues.redhat.com/browse/CONSOLE-4619

BREAKING: this PR removes co-external-link

tech debt, adding labels:
/label docs-approved
/label px-approved

/hold for prereq PR #15081

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/helm Related to helm-plugin component/knative Related to knative-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated plugin-api-changed Categorizes a PR as containing plugin API changes labels Jun 12, 2025
@logonoff logonoff force-pushed the CONSOLE-4619-extlink branch from dbc32e1 to 968152f Compare June 13, 2025 13:51
@openshift-ci openshift-ci bot added the kind/cypress Related to Cypress e2e integration testing label Jun 13, 2025
@logonoff
Copy link
Member Author

logonoff commented Jun 13, 2025 •
edited
Loading

this PR requres #15125 to be merged first due to a failing unit test

@logonoff logonoff force-pushed the CONSOLE-4619-extlink branch 4 times, most recently from 17d445c to 2e2ae56 Compare June 14, 2025 02:30
@logonoff logonoff force-pushed the CONSOLE-4619-extlink branch from 3d7fda2 to 6f82cf8 Compare June 15, 2025 01:59
@logonoff
Copy link
Member Author

logonoff commented Jun 15, 2025

PR is ready for code, plugin api, and qe review:
/assign @rhamilto @vojtechszocs @yapei

@logonoff
Copy link
Member Author

logonoff commented Jun 15, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2025
@logonoff logonoff force-pushed the CONSOLE-4619-extlink branch from 6f82cf8 to 31100e4 Compare June 16, 2025 12:34
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2025
rhamilto
rhamilto reviewed Jun 16, 2025
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Love this!

One i18n issue. Otherwise LVGTM.

frontend/packages/console-app/src/components/guided-tour/GuidedTourText.tsx Outdated
blog
</a>{' '}
<ExternalLink href={openshiftBlogLink} data-test="openshift-blog-link">
{t('console-app~blog')}
Copy link
Member

@rhamilto rhamilto Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use t inside a <Trans>

frontend/packages/console-app/src/components/guided-tour/GuidedTourText.tsx Outdated
documentation
</a>
<ExternalLink href={openshiftHelpBase} data-test="openshift-help-link">
{t('console-app~documentation')}
Copy link
Member

@rhamilto rhamilto Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use t inside a <Trans>

@logonoff logonoff requested a review from rhamilto June 16, 2025 18:14
@logonoff logonoff force-pushed the CONSOLE-4619-extlink branch from 31100e4 to e80f9f6 Compare June 16, 2025 18:14
@rhamilto
Copy link
Member

rhamilto commented Jun 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff
Copy link
Member Author

logonoff commented Jun 17, 2025

/label qe-approved

per jira comment by @yanpzhan

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 17, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4619 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

fixes https://issues.redhat.com/browse/CONSOLE-4619

BREAKING: this PR removes co-external-link

after new ExternalLinkWithCopy design:
image

after new ExternalLink:
image

tech debt, adding labels:
/label docs-approved
/label px-approved

/hold for prereq PR #15081

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

logonoff commented Jun 17, 2025

/skip

@rhamilto rhamilto removed the plugin-api-changed Categorizes a PR as containing plugin API changes label Jun 17, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 1db8825 into openshift:main Jun 17, 2025
7 checks passed
@logonoff logonoff deleted the CONSOLE-4619-extlink branch June 17, 2025 13:35
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 17, 2025

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.20.0-202506171641.p0.g1db8825.assembly.stream.el9.
All builds following this will include this PR.

@logonoff logonoff mentioned this pull request Jun 26, 2025
Merged
@logonoff logonoff mentioned this pull request Jul 7, 2025
Merged
yapei pushed a commit to yapei/console that referenced this pull request Jul 11, 2025
@openshift-merge-bot
Merge pull request openshift#15177 from logonoff/CONSOLE-4619-extlink
5b54de4 
CONSOLE-4619: Create `ExternalLinkButton` component and use it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cajieh cajieh Awaiting requested review from cajieh

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@vojtechszocs vojtechszocs

@rhamilto rhamilto

@spadgett spadgett

@jhadvig jhadvig

@yapei yapei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@logonoff @openshift-ci-robot @rhamilto @openshift-bot @vojtechszocs @spadgett @jhadvig @yapei @openshift-merge-robot