CONSOLE-4619: _blank removal followup
#15251
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@logonoff: This pull request references CONSOLE-4619 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
px-approved
|
@logonoff: This pull request references CONSOLE-4619 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
component/core
rhamilto
left a comment
rhamilto
left a comment
There was a problem hiding this comment.
Nice!
The HTML developer in me still winces as the sight of a <br />.
There was a problem hiding this comment.
| style={{ display: 'flex', flexDirection: 'column' }} |
logonoff
force-pushed
the
CONSOLE-4619-followup
branch
from
8aa346e to
183ccff
Compare
| className="co-break-all" | ||
| /> | ||
| <DescriptionListDescription key={link.url}> | ||
| <div className="pf-v6-u-display-flex pf-v6-u-flex-direction-column"> |
There was a problem hiding this comment.
This is fine, but it's more markup than my suggestion. :)
There was a problem hiding this comment.
Did you mean to use link.name as the text of the ExternalLink?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@logonoff: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-console |
4 participants
This PR removes some additional
_blanks that I did not address in the previous PR #15177.after:
updated
SystemStatusButtonto useExternalLinkButtonfixed visual regression in CSV sidebar:
addition of "opens in new tab" icon in
LinkifyExternal:code review:
/assign @rhamilto
follow up pr, adding labels
/label px-approved
/label docs-approved
/label qe-approved