Skip to content

CONSOLE-4595: Remove network-policies component in console-app #15125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jun 24, 2025
Merged

CONSOLE-4595: Remove network-policies component in console-app #15125

openshift-merge-bot merged 1 commit into from
Jun 24, 2025

Conversation

@cajieh
Copy link
Contributor

@cajieh cajieh commented Jun 4, 2025

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 4, 2025 •
edited by openshift-ci bot
Loading

@cajieh: This pull request references CONSOLE-4595 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 4, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2025
@openshift-ci openshift-ci bot requested review from Mylanos and jotak June 4, 2025 13:38
@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 4, 2025
@cajieh
Copy link
Contributor Author

cajieh commented Jun 9, 2025

/retest

@cajieh cajieh changed the title [WIP - NOT READY FOR REVIEW] CONSOLE-4595: Remove network-policies component in console-app [WIP] CONSOLE-4595: Remove network-policies component in console-app Jun 9, 2025
@cajieh cajieh force-pushed the remove-network-policies-redundant-code branch from fdd5591 to cca48fd Compare June 10, 2025 22:49
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jun 10, 2025
@cajieh cajieh force-pushed the remove-network-policies-redundant-code branch 2 times, most recently from 64c597c to 01ae3e7 Compare June 11, 2025 14:55
@openshift-ci openshift-ci bot added the component/shared Related to console-shared label Jun 11, 2025
@cajieh
Copy link
Contributor Author

cajieh commented Jun 11, 2025

/test frontend

@cajieh
Copy link
Contributor Author

cajieh commented Jun 11, 2025

/retest

@cajieh cajieh changed the title [WIP] CONSOLE-4595: Remove network-policies component in console-app CONSOLE-4595: Remove network-policies component in console-app Jun 12, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2025
@upalatucci
Copy link
Contributor

upalatucci commented Jun 12, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@cajieh
Copy link
Contributor Author

cajieh commented Jun 13, 2025

QA Approver:
/assign @yapei @yanpzhan

@logonoff
Copy link
Member

logonoff commented Jun 13, 2025

/lgtm

tech debt, adding labels
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jun 13, 2025
@logonoff logonoff mentioned this pull request Jun 13, 2025
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2025
@cajieh cajieh force-pushed the remove-network-policies-redundant-code branch from 01ae3e7 to f11320a Compare June 17, 2025 18:28
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2025
@cajieh
Copy link
Contributor Author

cajieh commented Jun 18, 2025

/retest

@cajieh cajieh force-pushed the remove-network-policies-redundant-code branch from f11320a to 07be118 Compare June 20, 2025 06:10
@yapei
Copy link
Contributor

yapei commented Jun 20, 2025

Network Policy regression testing passed, no issues found
Screenshot 2025-06-20 at 4 26 21 PM

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 20, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 20, 2025 •
edited by openshift-ci bot
Loading

@cajieh: This pull request references CONSOLE-4595 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh
Copy link
Contributor Author

cajieh commented Jun 20, 2025

/retest

1 similar comment
@cajieh
Copy link
Contributor Author

cajieh commented Jun 23, 2025

/retest

logonoff
logonoff approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, logonoff, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 23, 2025

/retest-required

Remaining retests: 0 against base HEAD 418db87 and 2 for PR HEAD 07be118 in total

@logonoff
Copy link
Member

logonoff commented Jun 24, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2025

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b77f40a into openshift:main Jun 24, 2025
7 checks passed
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 24, 2025

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.20.0-202506241811.p0.gb77f40a.assembly.stream.el9.
All builds following this will include this PR.

yapei pushed a commit to yapei/console that referenced this pull request Jul 11, 2025
@openshift-merge-bot
Merge pull request openshift#15125 from cajieh/remove-network-policie…
1215ad9 
…s-redundant-code

CONSOLE-4595: Remove network-policies component in console-app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jotak jotak Awaiting requested review from jotak

@Mylanos Mylanos Awaiting requested review from Mylanos

1 more reviewer

@logonoff logonoff logonoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@logonoff logonoff

@upalatucci upalatucci

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cajieh @openshift-ci-robot @upalatucci @logonoff @yapei @openshift-bot @openshift-merge-robot