Skip to content

Rename evaluation to result for feature flag evaluation result attributes #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 28, 2025
Merged

Rename evaluation to result for feature flag evaluation result attributes #1989

merged 7 commits into from
Mar 28, 2025

Conversation

@dyladan
Copy link
Member

@dyladan dyladan commented Mar 12, 2025

This came as a result of @trask reviewing the feature flag semconv to consolidate the naming hierarchy. result is a more direct term for the result of an evaluation. The result value and value type will also be incoming in separate PRs

@dyladan dyladan requested review from a team as code owners March 12, 2025 13:30
@lmolkova lmolkova moved this from Untriaged to Awaiting SIG approval in Semantic Conventions Triage Mar 17, 2025
@github-project-automation github-project-automation bot moved this from Awaiting SIG approval to Needs More Approval in Semantic Conventions Triage Mar 25, 2025
@trask
Copy link
Member

trask commented Mar 27, 2025

@dyladan can you resolve the merge conflict? will merge after, thanks!

@dyladan
Copy link
Member Author

dyladan commented Mar 28, 2025

@trask done

joaopgrassi
joaopgrassi reviewed Mar 28, 2025
View reviewed changes
@dyladan @joaopgrassi
Update schema-next.yaml
54bb02d 
Co-authored-by: Joao Grassi <[email protected]>
@trask trask merged commit 14e6df9 into open-telemetry:main Mar 28, 2025
15 checks passed
@MrAlias MrAlias mentioned this pull request May 15, 2025
Merged
MrAlias added a commit to open-telemetry/opentelemetry-go that referenced this pull request May 20, 2025
@MrAlias
Add semconv/v1.32.0 (#6782)
2d4c9dc 
- Add the new metric API package structure prototyped in
https://github.com/MrAlias/semconv-go

  Prototypes of new metric API use:
   - MrAlias/opentelemetry-go-contrib#6136
   - MrAlias/opentelemetry-go-contrib#6135
   - MrAlias/opentelemetry-go-contrib#6134
- Generate `semconv/v1.32.0`
- Drop the `kestrel` metric namespace as this is a Java specific
technology

## [`v1.32.0` semantic convention release
notes](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.32.0):

<div data-pjax="true" data-test-selector="body-content"
data-view-component="true" class="markdown-body my-3"><p>📣 This release
is the second release candidate for the Database Semantic Conventions,
with <strong>db conventions stability planned to be declared in the
subsequent release</strong>.</p>
<h3>🛑 Breaking changes 🛑</h3>
<ul>
<li><code>device</code>: Change the definition of <code>device.id</code>
and make it opt-in. (<a
href="open-telemetry/semantic-conventions#1874"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1874/hovercard">#1874</a>,
<a
href="open-telemetry/semantic-conventions#1951"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1951/hovercard">#1951</a>)</li>
<li><code>feature_flag</code>: Rename <code>evaluation</code> to
<code>result</code> for feature flag evaluation result attributes (<a
href="open-telemetry/semantic-conventions#1989"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1989/hovercard">#1989</a>)</li>
</ul>
<h3>🚀 New components 🚀</h3>
<ul>
<li><code>app</code>: Create <code>app.installation.id</code> attribute
(<a
href="open-telemetry/semantic-conventions#1874"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1874/hovercard">#1874</a>,
<a
href="open-telemetry/semantic-conventions#1897"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1897/hovercard">#1897</a>)</li>
<li><code>cpython</code>: Add CPython runtime garbage collector metrics
(<a
href="open-telemetry/semantic-conventions#1930"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1930/hovercard">#1930</a>)</li>
</ul>
<h3>💡 Enhancements 💡</h3>
<ul>
<li><code>vcs</code>: Add owner and provider name to VCS attribute
registry (<a
href="open-telemetry/semantic-conventions#1452"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1452/hovercard">#1452</a>)</li>
<li><code>vcs</code>: Remove fallback value for VCS provider name
attribute (<a
href="open-telemetry/semantic-conventions#2020"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2020/hovercard">#2020</a>)</li>
<li><code>db</code>: Truncate <code>db.query.summary</code> to 255
characters if parsed from the query (<a
href="open-telemetry/semantic-conventions#1978"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1978/hovercard">#1978</a>)</li>
<li><code>db</code>: Normalize spaces in <code>db.operation.name</code>
(if any) (<a
href="open-telemetry/semantic-conventions#2028"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2028/hovercard">#2028</a>)</li>
<li><code>db</code>: <code>db.operation.parameter.&lt;key&gt;</code>
should not be captured for batch operations (<a
href="open-telemetry/semantic-conventions#2026"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2026/hovercard">#2026</a>)</li>
<li><code>db</code>: Add <code>db.stored_procedure.name</code> (<a
href="open-telemetry/semantic-conventions#1491"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1491/hovercard">#1491</a>)</li>
<li><code>gcp</code>: Adds GCP AppHub labels for resource. (<a
href="open-telemetry/semantic-conventions#2006"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2006/hovercard">#2006</a>)</li>
<li><code>error</code>: Add <code>error.message</code> property for
human-readable error message on events. (<a
href="open-telemetry/semantic-conventions#1992"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1992/hovercard">#1992</a>)</li>
<li><code>profile</code>: Extend the list of known frame types with a
value for Go and Rust (<a
href="open-telemetry/semantic-conventions#2003"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2003/hovercard">#2003</a>)</li>
<li><code>otel</code>: Adds SDK self-monitoring metrics for log
processing (<a
href="open-telemetry/semantic-conventions#1921"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1921/hovercard">#1921</a>)</li>
</ul>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@trask trask trask approved these changes

@askpt askpt askpt approved these changes

@lukas-reining lukas-reining lukas-reining approved these changes

Assignees

No one assigned

Labels

breaking

Projects

Semantic Conventions Triage
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dyladan @trask @askpt @joaopgrassi @lukas-reining