Skip to content

Conversation

@MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jun 10, 2021

Changes

  • The go.opentelemetry.io/otel/exporters/metric/prometheus is renamed to go.opentelemetry.io/otel/exporters/prometheus.
  • The go.opentelemetry.io/otel/exporters/trace/jaeger is renamed to go.opentelemetry.io/otel/exporters/jaeger.
  • The go.opentelemetry.io/otel/exporters/trace/zipkin is renamed to go.opentelemetry.io/otel/exporters/zipkin.
  • Fix the dependabot check that was returning a false-positive check for the /trace and /metric modules.
  • Add dependabot entry for the /trace and /metric modules.

Background

All exporters used to be grouped in the metric or trace directory within the exporter directory. When we introduced metric support to the stdout and otlp exporters, which already supported tracing, they did not fit in either directory and were moved up one level. Now that the OTLP exporter is being split internally into trace and metric packages it has forced the question if the trace and metric directory within exporters makes sense.

It does not. It is an added hierarchical level to a package name that does not add useful context. Users of Prometheus know it is used for metrics and users of Jaeger and Zipkin know they are used for tracing.

This is a conclusion the rest of the OpenTelemetry SDKs have also realized. They have all included these exporters at the same directory level:

This change removes duplicate and unneeded hierarchical separation and unifies on a project structure closer matching the rest of the OpenTelemetry community.

@MrAlias MrAlias added release:1.0.0-rc.1 pkg:exporter:prometheus Related to the Prometheus exporter package pkg:exporter:jaeger Related to the Jaeger exporter package pkg:exporter:zipkin Related to the Zipkin exporter package labels Jun 10, 2021
@MrAlias MrAlias added this to the RC1 milestone Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #1992 (1e4c319) into main (7728a52) will decrease coverage by 33.6%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #1992      +/-   ##
========================================
- Coverage   77.3%   43.6%   -33.7%     
========================================
  Files        162     209      +47     
  Lines       8495   15496    +7001     
========================================
+ Hits        6567    6766     +199     
- Misses      1678    8354    +6676     
- Partials     250     376     +126     
Impacted Files Coverage Δ
exporters/jaeger/agent.go 73.4% <ø> (ø)
exporters/jaeger/assertsocketbuffersize.go 44.4% <ø> (ø)
exporters/jaeger/env.go 100.0% <ø> (ø)
...internal/gen-go/agent/agent-remote/agent-remote.go 0.0% <ø> (ø)
exporters/jaeger/internal/gen-go/agent/agent.go 6.0% <ø> (ø)
...gen-go/jaeger/collector-remote/collector-remote.go 0.0% <ø> (ø)
exporters/jaeger/internal/gen-go/jaeger/jaeger.go 3.5% <ø> (ø)
...zipkin_collector-remote/zipkin_collector-remote.go 0.0% <ø> (ø)
...rs/jaeger/internal/gen-go/zipkincore/zipkincore.go 0.0% <ø> (ø)
...arty/thrift/lib/go/thrift/application_exception.go 0.0% <ø> (ø)
... and 96 more

@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 10, 2021

Just remembered the decision was to deprecate instead of move. Will resubmit this.

@MrAlias MrAlias closed this Jun 10, 2021
MrAlias added a commit that referenced this pull request May 20, 2025
- Add the new metric API package structure prototyped in
https://github.com/MrAlias/semconv-go

  Prototypes of new metric API use:
   - MrAlias/opentelemetry-go-contrib#6136
   - MrAlias/opentelemetry-go-contrib#6135
   - MrAlias/opentelemetry-go-contrib#6134
- Generate `semconv/v1.32.0`
- Drop the `kestrel` metric namespace as this is a Java specific
technology

## [`v1.32.0` semantic convention release
notes](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.32.0):

<div data-pjax="true" data-test-selector="body-content"
data-view-component="true" class="markdown-body my-3"><p>📣 This release
is the second release candidate for the Database Semantic Conventions,
with <strong>db conventions stability planned to be declared in the
subsequent release</strong>.</p>
<h3>🛑 Breaking changes 🛑</h3>
<ul>
<li><code>device</code>: Change the definition of <code>device.id</code>
and make it opt-in. (<a
href="open-telemetry/semantic-conventions#1874"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1874/hovercard">#1874</a>,
<a
href="open-telemetry/semantic-conventions#1951"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1951/hovercard">#1951</a>)</li>
<li><code>feature_flag</code>: Rename <code>evaluation</code> to
<code>result</code> for feature flag evaluation result attributes (<a
href="open-telemetry/semantic-conventions#1989"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1989/hovercard">#1989</a>)</li>
</ul>
<h3>🚀 New components 🚀</h3>
<ul>
<li><code>app</code>: Create <code>app.installation.id</code> attribute
(<a
href="open-telemetry/semantic-conventions#1874"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1874/hovercard">#1874</a>,
<a
href="open-telemetry/semantic-conventions#1897"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1897/hovercard">#1897</a>)</li>
<li><code>cpython</code>: Add CPython runtime garbage collector metrics
(<a
href="open-telemetry/semantic-conventions#1930"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1930/hovercard">#1930</a>)</li>
</ul>
<h3>💡 Enhancements 💡</h3>
<ul>
<li><code>vcs</code>: Add owner and provider name to VCS attribute
registry (<a
href="open-telemetry/semantic-conventions#1452"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1452/hovercard">#1452</a>)</li>
<li><code>vcs</code>: Remove fallback value for VCS provider name
attribute (<a
href="open-telemetry/semantic-conventions#2020"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2020/hovercard">#2020</a>)</li>
<li><code>db</code>: Truncate <code>db.query.summary</code> to 255
characters if parsed from the query (<a
href="open-telemetry/semantic-conventions#1978"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1978/hovercard">#1978</a>)</li>
<li><code>db</code>: Normalize spaces in <code>db.operation.name</code>
(if any) (<a
href="open-telemetry/semantic-conventions#2028"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2028/hovercard">#2028</a>)</li>
<li><code>db</code>: <code>db.operation.parameter.&lt;key&gt;</code>
should not be captured for batch operations (<a
href="open-telemetry/semantic-conventions#2026"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/2026/hovercard">#2026</a>)</li>
<li><code>db</code>: Add <code>db.stored_procedure.name</code> (<a
href="open-telemetry/semantic-conventions#1491"
data-hovercard-type="issue"
data-hovercard-url="/open-telemetry/semantic-conventions/issues/1491/hovercard">#1491</a>)</li>
<li><code>gcp</code>: Adds GCP AppHub labels for resource. (<a
href="open-telemetry/semantic-conventions#2006"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2006/hovercard">#2006</a>)</li>
<li><code>error</code>: Add <code>error.message</code> property for
human-readable error message on events. (<a
href="open-telemetry/semantic-conventions#1992"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1992/hovercard">#1992</a>)</li>
<li><code>profile</code>: Extend the list of known frame types with a
value for Go and Rust (<a
href="open-telemetry/semantic-conventions#2003"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/2003/hovercard">#2003</a>)</li>
<li><code>otel</code>: Adds SDK self-monitoring metrics for log
processing (<a
href="open-telemetry/semantic-conventions#1921"
data-hovercard-type="pull_request"
data-hovercard-url="/open-telemetry/semantic-conventions/pull/1921/hovercard">#1921</a>)</li>
</ul>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:exporter:jaeger Related to the Jaeger exporter package pkg:exporter:prometheus Related to the Prometheus exporter package pkg:exporter:zipkin Related to the Zipkin exporter package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant