-
Notifications
You must be signed in to change notification settings - Fork 278
Rename evaluation to result for feature flag evaluation result attributes
#1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
820fa6d
Rename `evaluation` to `result` for feature flag evaluation result at…
dyladan fc9ead6
Add links to schema and chlog
dyladan 1160a12
Add deprecated ff attributes
dyladan f9658fa
Fix deprecated registry
dyladan f13c241
Fix yaml for real this time and regenerate table
dyladan faf7aa1
Merge remote-tracking branch 'origin/main' into ff-result-namespace
dyladan 54bb02d
Update schema-next.yaml
dyladan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: feature_flag | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Rename `evaluation` to `result` for feature flag evaluation result attributes | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [1989] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| groups: | ||
| - id: registry.feature_flag.deprecated | ||
| type: attribute_group | ||
| display_name: Deprecated Feature Flag Attributes | ||
| brief: "Describes deprecated feature flag attributes." | ||
| attributes: | ||
| - id: feature_flag.evaluation.reason | ||
| type: | ||
| members: | ||
| - id: static | ||
| value: "static" | ||
| brief: The resolved value is static (no dynamic evaluation). | ||
| stability: development | ||
| - id: default | ||
| value: "default" | ||
| brief: The resolved value fell back to a pre-configured value (no dynamic evaluation occurred or dynamic evaluation yielded no result). | ||
| stability: development | ||
| - id: targeting_match | ||
| value: "targeting_match" | ||
| brief: The resolved value was the result of a dynamic evaluation, such as a rule or specific user-targeting. | ||
| stability: development | ||
| - id: split | ||
| value: "split" | ||
| brief: The resolved value was the result of pseudorandom assignment. | ||
| stability: development | ||
| - id: cached | ||
| value: "cached" | ||
| brief: The resolved value was retrieved from cache. | ||
| stability: development | ||
| - id: disabled | ||
| value: "disabled" | ||
| brief: The resolved value was the result of the flag being disabled in the management system. | ||
| stability: development | ||
| - id: unknown | ||
| value: "unknown" | ||
| brief: The reason for the resolved value could not be determined. | ||
| stability: development | ||
| - id: stale | ||
| value: "stale" | ||
| brief: The resolved value is non-authoritative or possibly out of date | ||
| stability: development | ||
| - id: error | ||
| value: "error" | ||
| brief: The resolved value was the result of an error. | ||
| stability: development | ||
| brief: 'Deprecated, use `feature_flag.result.reason` instead.' | ||
| stability: development | ||
| deprecated: "Replaced by `feature_flag.result.reason`." | ||
| examples: ["static", "targeting_match", "error", "default"] | ||
| - id: feature_flag.variant | ||
| type: string | ||
| brief: 'Deprecated, use `feature_flag.result.variant` instead.' | ||
| stability: development | ||
| deprecated: "Replaced by `feature_flag.result.variant`." | ||
| examples: ["red", "true", "on"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.