Skip to content

Conversation

@didiViking
Copy link
Contributor

Related to #7760

@didiViking
Copy link
Contributor Author

@victorvarza @dnanuti @IrinaKarantoniou Please review the Romanian content, this is the page that's being translated: https://opentelemetry.io/docs/what-is-opentelemetry/. The guidelines for localization are here. If all good, reply with LGTM. Thank you!

@didiViking didiViking requested a review from dnanuti September 26, 2025 15:35
@dnanuti
Copy link

dnanuti commented Sep 26, 2025

LGTM, left some nits / questions! Thank you! 🙏

@vitorvasc vitorvasc added the sig-approval-missing Co-owning SIG didn't provide an approval label Sep 26, 2025
@didiViking
Copy link
Contributor Author

@svrnm @vitorvasc I need some adding to the queue for merging, Romanian content has been approved. Thank you!

@IrinaKarantoniou
Copy link

@didiViking Diana, since I am new and have absolutely no experience with GitHub, I left a comment on the file, but I do not know if you can see it. Is this part missing from the translation: "A major goal of OpenTelemetry is to enable easy instrumentation of your applications and systems, regardless of the programming language, infrastructure, and runtime environments used"?

@didiViking
Copy link
Contributor Author

@didiViking Diana, since I am new and have absolutely no experience with GitHub, I left a comment on the file, but I do not know if you can see it. Is this part missing from the translation: "A major goal of OpenTelemetry is to enable easy instrumentation of your applications and systems, regardless of the programming language, infrastructure, and runtime environments used"?

Good catch. I've now added the paragraph.

@didiViking
Copy link
Contributor Author

@IrinaKarantoniou Please review the final commit, if all ok, comment with LGTM. Thank you for your review!

@IrinaKarantoniou
Copy link

LGTM! I'd say PERFECT!!

@svrnm svrnm removed the sig-approval-missing Co-owning SIG didn't provide an approval label Sep 29, 2025
@svrnm svrnm added this pull request to the merge queue Sep 29, 2025
Merged via the queue into open-telemetry:main with commit c983667 Sep 29, 2025
22 checks passed
Pentru mai multe videoclipuri din această serie și resurse suplimentare, vezi
[Ce urmează?](#what-next)

## Ce este observabilitatea?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading IDs are missing here and elsewhere. This breaks link checking, see:

svrnm pushed a commit to svrnm/opentelemetry.io that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants