-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[chore] [pdata] Avoid allocations when copy oneOf fields #13291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (79.66%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13291 +/- ##
==========================================
- Coverage 91.46% 91.44% -0.03%
==========================================
Files 536 536
Lines 29590 29625 +35
==========================================
+ Hits 27065 27090 +25
- Misses 1994 2004 +10
Partials 531 531 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
contrib tests are fixed in open-telemetry/opentelemetry-collector-contrib#40978 |
Should the new code path be tested? |
It's actually already covered. We just don't test every option for the primitive oneOf's. In |
7e003ca
to
7b4c926
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
7b4c926
to
c77c886
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Similar to #13290, for oneOf fields