[chore] [pdata] Avoid an allocation when copy an optional field #13290
Conversation
dmitryax
requested review from
a team,
bogdandrutu,
dmathieu and
mx-psi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13290 +/- ##
==========================================
- Coverage 91.64% 91.63% -0.02%
==========================================
Files 522 522
Lines 29183 29223 +40
==========================================
+ Hits 26746 26778 +32
- Misses 1920 1926 +6
- Partials 517 519 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
contrib tests are fixed in open-telemetry/opentelemetry-collector-contrib#40978 |
dmitryax
force-pushed
the
address-pdatagen-comment
branch
from
ebfd397 to
46f8c45
Compare
| dest{{ .fieldName }} = &{{ .originStructType }}{} | ||
| dest.{{ .fieldName }}_ = dest{{ .fieldName }} | ||
| } | ||
| dest{{ .fieldName }}.{{ .fieldName }} = src.Get{{ .fieldName }}() |
There was a problem hiding this comment.
Why using the Getter that checks for nil since is not nil?
There was a problem hiding this comment.
@bogdandrutu please take another look since it required significant enough change
|
|
||
| const optionalPrimitiveCopyOrigTemplate = `if src.{{ .fieldName }}_ == nil { | ||
| dest.{{ .fieldName }}_ = nil | ||
| } else { |
There was a problem hiding this comment.
nit: Can we return instead here, avoids an indentation.
There was a problem hiding this comment.
No, it's rendered as part of copying one field while there may be others after that. Only if we move this to a separate function
dmitryax
force-pushed
the
address-pdatagen-comment
branch
from
46f8c45 to
3090436
Compare
3 participants
Addresses #13267 (comment)