Skip to content

[chore] [pdata] Avoid allocations when copy oneOf fields #13291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[chore] [pdata] Avoid allocations when copy oneOf fields #13291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions internal/cmd/pdatagen/internal/base_fields.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,14 @@ const oneOfMessageSetTestFieldTemplate = `tv.orig.{{ .originOneOfFieldName }} =
fillTest{{ .returnType }}(new{{ .returnType }}(tv.orig.Get{{ .returnType }}(), tv.state))`

const copyToValueOneOfMessageTemplate = ` case *{{ .originStructType }}:
{{ .lowerFieldName }} := &{{ .originFieldPackageName}}.{{ .fieldName }}{}
copyOrig{{ .returnType }}({{ .lowerFieldName }}, t.{{ .fieldName }})
dest.{{ .originOneOfFieldName }} = &{{ .originStructType }}{
{{ .fieldName }}: {{ .lowerFieldName }},
}`
{{ .lowerFieldName }}, ok := dest.{{ .originOneOfFieldName }}.(*{{ .originStructType }})
if !ok || {{ .lowerFieldName }}.{{ .fieldName }} == nil {
{{ .lowerFieldName }} = &{{ .originStructType }}{
{{ .fieldName }}: &{{ .originFieldPackageName}}.{{ .fieldName }}{},
}
dest.{{ .originOneOfFieldName }} = {{ .lowerFieldName }}
}
copyOrig{{ .returnType }}({{ .lowerFieldName }}.{{ .fieldName }}, t.{{ .fieldName }})`

const accessorsOneOfPrimitiveTemplate = `// {{ .accessorFieldName }} returns the {{ .lowerFieldName }} associated with this {{ .structName }}.
func (ms {{ .structName }}) {{ .accessorFieldName }}() {{ .returnType }} {
Expand Down Expand Up @@ -218,8 +221,12 @@ const oneOfPrimitiveSetTestFieldTemplate = `tv.orig.{{ .originOneOfFieldName }}
{{- .originFieldName }}: {{ .testValue }}}`

const oneOfPrimitiveCopyOrigFieldTemplate = `case *{{ .originStructName }}_{{ .originFieldName }}:
dest.{{ .originOneOfFieldName }} = &{{ .originStructName }}_{{ .originFieldName }}{
{{- .originFieldName }}: t.{{ .originFieldName }}}`
dest{{ .originOneOfFieldName }}, ok := dest.{{ .originOneOfFieldName }}.(*{{ .originStructName }}_{{ .originFieldName }})
if !ok {
dest{{ .originOneOfFieldName }} = &{{ .originStructName }}_{{ .originFieldName }}{}
dest.{{ .originOneOfFieldName }} = dest{{ .originOneOfFieldName }}
}
dest{{ .originOneOfFieldName }}.{{ .originFieldName }} = t.{{ .originFieldName }}`

const oneOfPrimitiveSwitchCaseTemplate = `case *{{ .originStructName }}_{{ .originFieldName }}:
return {{ .typeName }}`
Expand Down
14 changes: 12 additions & 2 deletions pdata/pmetric/generated_exemplar.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

55 changes: 35 additions & 20 deletions pdata/pmetric/generated_metric.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 12 additions & 2 deletions pdata/pmetric/generated_numberdatapoint.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading