Skip to content

Conversation

gasche
Copy link
Member

@gasche gasche commented Dec 20, 2017

This is the solution to build problems affecting cohttp proposed in

mirage/ocaml-cohttp#591

My first attempt at fixing the cohttp issue was #11085, but it seems to be the wrong approach.

I had to look at other files in the repository to remember whether & or | should be used for multi-version conflicts, but this seems to be it. (It's not intuitive at all.)

This is the solution to build problems affecting cohttp proposed in

  mirage/ocaml-cohttp#591
@camelus
Copy link
Contributor

camelus commented Dec 20, 2017

✅ All lint checks passed 53a126c
  • These packages passed lint tests: ppx_type_conv.v0.9.0

✅ Installability check (8011 → 8011)

@hannesm hannesm self-assigned this Dec 21, 2017
@hannesm
Copy link
Member

hannesm commented Dec 21, 2017

@gasche thanks for fixing this constraint. I agree that the & and | in conflicts is very unintuitive, maybe @AltGr has an opinion (or fix in 2.0)!?

This conflict was proposed in the cohttp issue, merging since it improves the situation.

@hannesm hannesm merged commit d84cb5e into ocaml:master Dec 21, 2017
@gasche gasche mentioned this pull request Dec 21, 2017
gasche added a commit to gasche/opam-repository that referenced this pull request Dec 22, 2017
see ocaml#11086 for previous
version -- too restrictive -- of the conflict clause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants