restrict OCaml version for older cohttp versions #11085
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ All lint checks passed ba83c95
✅ Installability check (8011 → 8011) |
CI results from ocaml#11076 seem to indicate that older cohttp versions still get selected by the dependency solver, and are incompatible with recent OCaml version: the only thing I know for sure is that 0.20.1 is incompatible with both 4.05 and 4.06. This tentative PR touches a range of cohttp versions (restrict them to < 4.06, which seems correct given the bound on 0.99) to check them against OCaml versions -- it may turn out that they are all incompatible with 4.05 as well, in which case they would all be restricted. (I didn't do it on *all* older cohttp version to avoid CI overload.)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI results from #11076
seem to indicate that older cohttp versions still get selected by the
dependency solver, and are incompatible with recent OCaml version: the
only thing I know for sure is that 0.20.1 is incompatible with both
4.05 and 4.06. This tentative PR touches a range of cohttp versions
(restrict them to < 4.06, which seems correct given the bound on 0.99)
to check them against OCaml versions -- it may turn out that they are
all incompatible with 4.05 as well, in which case they would all be
restricted.
(I didn't do it on all older cohttp version to avoid CI overload.)