Skip to content

Conversation

rgrinberg
Copy link
Member

Previous versions don't interact with ppx_deriving that well.

Best would be to somehow black list this version in opam-repository. But it doesn't hurt adding this here.

@hannesm

Previous versions don't interact with ppx_deriving that well
@hannesm
Copy link
Member

hannesm commented Dec 19, 2017

@rgrinberg thanks! if ppx_type_conv v0.9.0 does not work anywhere (does it work anywhere?), I'd be in favour of deleting it from opam-repository!?
as far as I understand @diml, ppx_type_conv v0.9.0 needs a conflict with ppx_deriving.4.2!? once this is added, is this change here needed (well, if cohttp depends on ppx_type_conv, it should have a dependency in opam). I'm not familiar with either ppx_type_conv, ppx_deriving, nor cohttp to judge which change(s) are needed.

@rgrinberg
Copy link
Member Author

if ppx_type_conv v0.9.0 does not work anywhere (does it work anywhere?), I'd be in favour of deleting it from opam-repository!?

It does work for other converters that don't generate modules, since in this situation generating the same code doesn't hurt.

@ghost
Copy link

ghost commented Dec 19, 2017

Adding the conflict seems fine. Hopefully it shouldn't make packages uninstallable

gasche added a commit to gasche/opam-repository that referenced this pull request Dec 20, 2017
This is the solution to build problems affecting cohttp proposed in

  mirage/ocaml-cohttp#591
@avsm avsm merged commit d5223f3 into mirage:master Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants